-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix - Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB #78752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix - Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB #78752
Conversation
…pening create manual from QAB
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
REady for review @hoangzinh |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-05.at.20.57.42.android.movAndroid: mWeb ChromeScreen.Recording.2026-01-05.at.20.40.11.android.c.moviOS: HybridAppScreen.Recording.2026-01-05.at.21.19.53.moviOS: mWeb SafariScreen.Recording.2026-01-05.at.21.02.40.ios.s.movMacOS: Chrome / SafariScreen.Recording.2026-01-05.at.20.38.10.web.mov |
hoangzinh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
justinpersaud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty trivial change with no design/product changes so going to merge
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/justinpersaud in version: 9.2.93-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.93-1 🚀
|
…ding-bug fix - Confirm page loads infinitely after opening scan shortcut and opening create manual from QAB
Explanation of Change
This is identical to #76846 which was reverted due to onyx bug.
Fixed Issues
$ #75046
PROPOSAL: #75046 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-12-06.00-58-55.mp4
Android: mWeb Chrome
2025-12-05.22-21-02.mp4
iOS: Native
2025-12-05.21-43-34.mp4
iOS: mWeb Safari
2025-12-05.22-20-25.mp4
MacOS: Chrome / Safari
2025-12-05.22-20-08.mp4