Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/OptionsListUtils.ts

[abzokhattab]

Explanation of Change

Fixed Issues

$ #66374
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/LHNOptionsList/OptionRowLHNData.tsx	86.95% <100.00%> (+0.59%)	⬆️
src/components/Search/SearchAutocompleteList.tsx	32.27% <100.00%> (ø)
src/hooks/useContactImport.ts	100.00% <100.00%> (ø)
src/libs/ContactUtils.ts	50.00% <ø> (ø)
src/libs/SidebarUtils.ts	80.70% <100.00%> (ø)
src/pages/NewChatPage.tsx	76.84% <100.00%> (+0.49%)	⬆️
...ponents/Search/FilterDropdowns/UserSelectPopup.tsx	4.25% <0.00%> (ø)
src/libs/actions/IOU/index.ts	66.47% <0.00%> (-0.22%)	⬇️
...u/request/step/IOURequestStepScan/index.native.tsx	0.77% <0.00%> (ø)
...ages/iou/request/step/IOURequestStepScan/index.tsx	0.00% <0.00%> (ø)
... and 10 more
... and 7 files with indirect coverage changes

[melvin-bot]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[abzokhattab]

PR is ready but i am confused about the manual test we should make in this case @DylanDylann what do u think

replaced the the session with useOnyx in all usages and removed the connect

[DylanDylann]

@abzokhattab This PR is quite large. Could you please split it into smaller PRs? It’s difficult to move forward with such a big PR.

[DylanDylann]

@abzokhattab For testing, you can pick a sample flow. There’s no need to test all flows related to these changes

[abzokhattab]

i agree the changes are abit big but i dont think we need a second PR ... i mean we are not changing anything in the logic just passing the values from onyx .... so it shouldnt be hard to review...

that said here are the functions that were modified we just need to ensure that all of their usages are passing the new params

In src/libs/OptionsListUtils/index.ts:

1. getLastActorDisplayName - added currentUserAccountID
2. shouldShowLastActorDisplayName - added currentUserAccountID
3. getLastActorDisplayNameFromLastVisibleActions - added currentUserAccountID
4. isCurrentUser - added currentUserEmail
5. getPersonalDetailSearchTerms - added currentUserAccountID
6. getManagerMcTestParticipant - added currentUserAccountID
7. getFilteredRecentAttendees - added currentUserEmail, currentUserAccountID
8. isValidReport - added currentUserAccountID (via config)
9. getValidOptions - added currentUserAccountID, currentUserEmail (via config)
10. getSearchOptions - added currentUserAccountID, currentUserEmail
11. filterPersonalDetails - added currentUserAccountID
12. getUserToInviteOption - added currentUserEmail (via config)
13. getUserToInviteContactOption - added currentUserEmail (via config)
14. filterUserToInvite - added currentUserEmail (via config)
15. filterOptions - added currentUserAccountID, currentUserEmail
16. filterAndOrderOptions - added currentUserAccountID, currentUserEmail (email via config)
17. formatSectionsFromSearchTerm - added currentUserAccountID
18. getMemberInviteOptions - added currentUserAccountID, currentUserEmail

In src/libs/OptionsListUtils/types.ts:

Updated types to include the new parameters:

• IsValidReportsConfig - added currentUserAccountID
• GetOptionsConfig - added currentUserAccountID, currentUserEmail
• GetUserToInviteConfig - added currentUserEmail
• FilterUserToInviteConfig - added currentUserEmail
• SearchOptionsConfig - added currentUserAccountID, currentUserEmail

In src/libs/ContactUtils.ts:

19. getContacts - added currentUserEmail

what do u think ?

cc @tgolen

[tgolen]

Yeah, you probably don't need to do 1 PR for each method, but I think a smaller PR would still be ideal. What about splitting it up so that each PR only modifies 5 methods? I'd also be sure to add unit tests to each method being modified.

[DylanDylann]

From my experience, I think a PR should have at most 200–300 changed lines. Each PR can refactor a few methods, and in some cases we may need multiple PRs to handle a single method, it really depends on the situation.