Skip to content

Conversation

@carlosmiceli
Copy link
Contributor

@carlosmiceli carlosmiceli commented Jan 2, 2026

Explanation of Change

Remove cardholder label in RHP to keep it consistent with the rest of the app.

Fixed Issues

https://github.com/Expensify/Expensify/issues/570675

Tests

1- Go to Company Cards (there needs to be a feed connected)
2- Click on Assign on any unassigned card
3- Select a member
4- Confirm the row looks like the image on hover:
Screenshot 2026-01-07 at 4 43 42 PM

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@carlosmiceli carlosmiceli self-assigned this Jan 2, 2026
@carlosmiceli carlosmiceli requested review from a team as code owners January 2, 2026 00:23
@melvin-bot melvin-bot bot requested a review from nkuoch January 2, 2026 00:23
@melvin-bot
Copy link

melvin-bot bot commented Jan 2, 2026

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team January 2, 2026 00:23
@carlosmiceli carlosmiceli removed the request for review from nkuoch January 2, 2026 00:24
@carlosmiceli
Copy link
Contributor Author

@dannymcclain could you confirm this is what you were expecting? Thank you!

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...space/companyCards/assignCard/ConfirmationStep.tsx 0.00% <0.00%> (ø)
... and 5 files with indirect coverage changes

@hungvu193
Copy link
Contributor

LGTM. Just waiting for confirmation

@dannymcclain
Copy link
Contributor

I don't think we want to remove the label here - we just want this row to behave/look like our other rows that show this type of avatar lock up. Here's an example from the create expense flow:

CleanShot 2026-01-05 at 10 49 55

If I'm remembering correctly, before we had the Cardholder label inside the push row hover with the avatar lock up. I think we just need to update it to look/behave like that To field from create expense. cc @dubielzyk-expensify

@dubielzyk-expensify
Copy link
Contributor

Agree we don't wanna remove the label. I'd expect to see it exactly how we do it on the card details page:

CleanShot 2026-01-06 at 08 58 24@2x

@carlosmiceli
Copy link
Contributor Author

Great, this should be it then! cc @hungvu193

Screenshot 2026-01-05 at 8 29 04 PM

@dubielzyk-expensify
Copy link
Contributor

Shouldn't the user have email repeated twice with both the bold text and the subtitle, like this?
CleanShot 2026-01-06 at 10 05 01@2x

Just one of them looks a bit off to me

@carlosmiceli
Copy link
Contributor Author

Shouldn't the user have email repeated twice with both the bold text and the subtitle, like this?

We can change that, sure, I think we intentionally removed it during the sprint week, but maybe @dannymcclain can confirm.

@dubielzyk-expensify
Copy link
Contributor

We do the double email when we have email and no name pretty much everywhere in the app so I'd be hesitant for the sake of consistency, but let's hear what Dman says 👍

@OSBotify

This comment has been minimized.

@hungvu193
Copy link
Contributor

Looks like we still have linting @carlosmiceli

@dannymcclain
Copy link
Contributor

We do the double email when we have email and no name pretty much everywhere in the app so I'd be hesitant for the sake of consistency, but let's hear what Dman says 👍

Ah that's my bad. I thought we removed the subtitle and just displayed the email big and bold if we didn't have a display name. But if the double way is how we do it everywhere else, let's just do it the same way here!

@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2026

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 0b9643ea..a6f4fde8 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4840,7 +4840,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
             fromTheBeginning: 'Von Anfang an',
             customStartDate: 'Benutzerdefiniertes Startdatum',
             customCloseDate: 'Benutzerdefiniertes Abschlussdatum',
-            letsDoubleCheck: 'Lass uns noch einmal überprüfen, ob alles richtig aussieht.',
+            letsDoubleCheck: 'Lassen Sie uns noch einmal überprüfen, ob alles richtig aussieht.',
             confirmationDescription: 'Wir beginnen sofort mit dem Import der Transaktionen.',
             card: 'Karte',
             cardName: 'Kartenname',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 36df8866..465ecd66 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4824,8 +4824,8 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
             fromTheBeginning: "Dall'inizio",
             customStartDate: 'Data di inizio personalizzata',
             customCloseDate: 'Data di chiusura personalizzata',
-            letsDoubleCheck: 'Controlliamo ancora una volta che tutto sia corretto.',
-            confirmationDescription: 'Inizieremo subito a importare le transazioni.',
+            letsDoubleCheck: 'Controlliamo un’ultima volta che sia tutto corretto.',
+            confirmationDescription: 'Inizieremo a importare le transazioni immediatamente.',
             card: 'Carta',
             cardName: 'Nome carta',
             brokenConnectionError: '<rbr>La connessione al feed della carta è interrotta. Per favore <a href="#">accedi alla tua banca</a> così possiamo ristabilire la connessione.</rbr>',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index a7d98dc4..97377423 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4798,8 +4798,8 @@ _より詳しい手順については、[ヘルプサイトをご覧ください
             fromTheBeginning: '最初から',
             customStartDate: 'カスタム開始日',
             customCloseDate: 'カスタム締め日',
-            letsDoubleCheck: 'すべてが正しく見えるか、もう一度確認しましょう。',
-            confirmationDescription: '取引のインポートを直ちに開始します。',
+            letsDoubleCheck: 'すべて正しく見えるか、もう一度確認しましょう。',
+            confirmationDescription: 'すぐに取引のインポートを開始します。',
             card: 'カード',
             cardName: 'カード名',
             brokenConnectionError: '<rbr>カードフィード接続が切断されています。再度接続を確立するために、<a href="#">銀行にログイン</a>してください。</rbr>',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 1c804855..45979868 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4819,7 +4819,7 @@ _Voor gedetailleerdere instructies, [bezoek onze helpsite](${CONST.NETSUITE_IMPO
             fromTheBeginning: 'Vanaf het begin',
             customStartDate: 'Aangepaste startdatum',
             customCloseDate: 'Aangepaste einddatum',
-            letsDoubleCheck: 'Laten we nog eens controleren of alles er goed uitziet.',
+            letsDoubleCheck: 'Laten we nog even controleren of alles er goed uitziet.',
             confirmationDescription: 'We beginnen onmiddellijk met het importeren van transacties.',
             card: 'Kaart',
             cardName: 'Kaartnaam',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 4f5f63f2..6abf8ee7 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4810,8 +4810,8 @@ _Para instruções mais detalhadas, [visite nosso site de ajuda](${CONST.NETSUIT
             fromTheBeginning: 'Desde o início',
             customStartDate: 'Data de início personalizada',
             customCloseDate: 'Data de fechamento personalizada',
-            letsDoubleCheck: 'Vamos conferir se está tudo certo.',
-            confirmationDescription: 'Começaremos a importar transações imediatamente.',
+            letsDoubleCheck: 'Vamos conferir se está tudo correto.',
+            confirmationDescription: 'Começaremos a importar as transações imediatamente.',
             card: 'Cartão',
             cardName: 'Nome do cartão',
             brokenConnectionError: '<rbr>A conexão com o feed do cartão foi interrompida. Por favor, <a href="#">faça login no seu banco</a> para que possamos restabelecer a conexão.</rbr>',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 6da3a5bc..0d9276a7 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4726,8 +4726,8 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
             fromTheBeginning: '从头开始',
             customStartDate: '自定义开始日期',
             customCloseDate: '自定义结束日期',
-            letsDoubleCheck: '让我们再仔细检查一下,确保一切都正确。',
-            confirmationDescription: '我们会立即开始导入交易。',
+            letsDoubleCheck: '让我们再仔细检查一下,以确保一切都正确。',
+            confirmationDescription: '我们将立即开始导入交易记录。',
             card: '卡片',
             cardName: '卡片名称',
             brokenConnectionError: '<rbr>银行卡信息连接已中断。请<a href="#">登录您的银行账户</a>以便我们重新建立连接。</rbr>',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

@carlosmiceli
Copy link
Contributor Author

@hungvu193 ready.

@hungvu193
Copy link
Contributor

hungvu193 commented Jan 7, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-01-07.at.14.10.09.mov
Android: mWeb Chrome
Screen.Recording.2026-01-07.at.14.04.52.mov
iOS: HybridApp
Screen.Recording.2026-01-07.at.13.58.05.mov
iOS: mWeb Safari
Screen.Recording.2026-01-07.at.13.58.05.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-07.at.13.55.47.mov

@melvin-bot melvin-bot bot requested a review from mjasikowski January 7, 2026 07:11
@melvin-bot
Copy link

melvin-bot bot commented Jan 7, 2026

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
Copy link

melvin-bot bot commented Jan 7, 2026

🎯 @hungvu193, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #78972.

Copy link
Contributor

@mjasikowski mjasikowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gucci!

@mjasikowski mjasikowski requested a review from tgolen January 7, 2026 08:11
@dannymcclain
Copy link
Contributor

Looks good to me too cc @Expensify/design

Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the tests and QA section before merging this.

@carlosmiceli carlosmiceli merged commit 7325b34 into main Jan 7, 2026
39 checks passed
@carlosmiceli carlosmiceli deleted the cm-polish-cardholder-label branch January 7, 2026 19:45
@OSBotify
Copy link
Contributor

OSBotify commented Jan 7, 2026

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants