-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Remove cardholder label from card assignment #78764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dannymcclain could you confirm this is what you were expecting? Thank you! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
LGTM. Just waiting for confirmation |
|
I don't think we want to remove the label here - we just want this row to behave/look like our other rows that show this type of avatar lock up. Here's an example from the create expense flow: If I'm remembering correctly, before we had the Cardholder label inside the push row hover with the avatar lock up. I think we just need to update it to look/behave like that To field from create expense. cc @dubielzyk-expensify |
|
Great, this should be it then! cc @hungvu193
|
We can change that, sure, I think we intentionally removed it during the sprint week, but maybe @dannymcclain can confirm. |
|
We do the double email when we have email and no name pretty much everywhere in the app so I'd be hesitant for the sake of consistency, but let's hear what Dman says 👍 |
This comment has been minimized.
This comment has been minimized.
|
Looks like we still have linting @carlosmiceli |
Ah that's my bad. I thought we removed the subtitle and just displayed the email big and bold if we didn't have a display name. But if the double way is how we do it everywhere else, let's just do it the same way here! |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 0b9643ea..a6f4fde8 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -4840,7 +4840,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
fromTheBeginning: 'Von Anfang an',
customStartDate: 'Benutzerdefiniertes Startdatum',
customCloseDate: 'Benutzerdefiniertes Abschlussdatum',
- letsDoubleCheck: 'Lass uns noch einmal überprüfen, ob alles richtig aussieht.',
+ letsDoubleCheck: 'Lassen Sie uns noch einmal überprüfen, ob alles richtig aussieht.',
confirmationDescription: 'Wir beginnen sofort mit dem Import der Transaktionen.',
card: 'Karte',
cardName: 'Kartenname',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 36df8866..465ecd66 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -4824,8 +4824,8 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
fromTheBeginning: "Dall'inizio",
customStartDate: 'Data di inizio personalizzata',
customCloseDate: 'Data di chiusura personalizzata',
- letsDoubleCheck: 'Controlliamo ancora una volta che tutto sia corretto.',
- confirmationDescription: 'Inizieremo subito a importare le transazioni.',
+ letsDoubleCheck: 'Controlliamo un’ultima volta che sia tutto corretto.',
+ confirmationDescription: 'Inizieremo a importare le transazioni immediatamente.',
card: 'Carta',
cardName: 'Nome carta',
brokenConnectionError: '<rbr>La connessione al feed della carta è interrotta. Per favore <a href="#">accedi alla tua banca</a> così possiamo ristabilire la connessione.</rbr>',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index a7d98dc4..97377423 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -4798,8 +4798,8 @@ _より詳しい手順については、[ヘルプサイトをご覧ください
fromTheBeginning: '最初から',
customStartDate: 'カスタム開始日',
customCloseDate: 'カスタム締め日',
- letsDoubleCheck: 'すべてが正しく見えるか、もう一度確認しましょう。',
- confirmationDescription: '取引のインポートを直ちに開始します。',
+ letsDoubleCheck: 'すべて正しく見えるか、もう一度確認しましょう。',
+ confirmationDescription: 'すぐに取引のインポートを開始します。',
card: 'カード',
cardName: 'カード名',
brokenConnectionError: '<rbr>カードフィード接続が切断されています。再度接続を確立するために、<a href="#">銀行にログイン</a>してください。</rbr>',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 1c804855..45979868 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -4819,7 +4819,7 @@ _Voor gedetailleerdere instructies, [bezoek onze helpsite](${CONST.NETSUITE_IMPO
fromTheBeginning: 'Vanaf het begin',
customStartDate: 'Aangepaste startdatum',
customCloseDate: 'Aangepaste einddatum',
- letsDoubleCheck: 'Laten we nog eens controleren of alles er goed uitziet.',
+ letsDoubleCheck: 'Laten we nog even controleren of alles er goed uitziet.',
confirmationDescription: 'We beginnen onmiddellijk met het importeren van transacties.',
card: 'Kaart',
cardName: 'Kaartnaam',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 4f5f63f2..6abf8ee7 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -4810,8 +4810,8 @@ _Para instruções mais detalhadas, [visite nosso site de ajuda](${CONST.NETSUIT
fromTheBeginning: 'Desde o início',
customStartDate: 'Data de início personalizada',
customCloseDate: 'Data de fechamento personalizada',
- letsDoubleCheck: 'Vamos conferir se está tudo certo.',
- confirmationDescription: 'Começaremos a importar transações imediatamente.',
+ letsDoubleCheck: 'Vamos conferir se está tudo correto.',
+ confirmationDescription: 'Começaremos a importar as transações imediatamente.',
card: 'Cartão',
cardName: 'Nome do cartão',
brokenConnectionError: '<rbr>A conexão com o feed do cartão foi interrompida. Por favor, <a href="#">faça login no seu banco</a> para que possamos restabelecer a conexão.</rbr>',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 6da3a5bc..0d9276a7 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -4726,8 +4726,8 @@ _如需更详细的说明,请[访问我们的帮助网站](${CONST.NETSUITE_IM
fromTheBeginning: '从头开始',
customStartDate: '自定义开始日期',
customCloseDate: '自定义结束日期',
- letsDoubleCheck: '让我们再仔细检查一下,确保一切都正确。',
- confirmationDescription: '我们会立即开始导入交易。',
+ letsDoubleCheck: '让我们再仔细检查一下,以确保一切都正确。',
+ confirmationDescription: '我们将立即开始导入交易记录。',
card: '卡片',
cardName: '卡片名称',
brokenConnectionError: '<rbr>银行卡信息连接已中断。请<a href="#">登录您的银行账户</a>以便我们重新建立连接。</rbr>',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@hungvu193 ready. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-07.at.14.10.09.movAndroid: mWeb ChromeScreen.Recording.2026-01-07.at.14.04.52.moviOS: HybridAppScreen.Recording.2026-01-07.at.13.58.05.moviOS: mWeb SafariScreen.Recording.2026-01-07.at.13.58.05.movMacOS: Chrome / SafariScreen.Recording.2026-01-07.at.13.55.47.mov |
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @hungvu193, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #78972. |
mjasikowski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks gucci!
|
Looks good to me too cc @Expensify/design |
tgolen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill out the tests and QA section before merging this.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |




Explanation of Change
Remove cardholder label in RHP to keep it consistent with the rest of the app.
Fixed Issues
https://github.com/Expensify/Expensify/issues/570675
Tests
1- Go to Company Cards (there needs to be a feed connected)

2- Click on Assign on any unassigned card
3- Select a member
4- Confirm the row looks like the image on hover:
Offline tests
QA Steps
Same as tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari