Fix: Cannot navigate duplicated expenses via arrow keys #78857

cretadn22 · 2026-01-05T16:48:02Z

Explanation of Change

Fixed Issues

$ #77286
PROPOSAL: #77286 (comment)

Tests

Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Open the expense report.
Open any expense.
Click More > Duplicate.
Use arrows on the top right to navigate to the duplicated expense.
Duplicated expense can be navigated via arrows.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Open the expense report.
Open any expense.
Click More > Duplicate.
Use arrows on the top right to navigate to the duplicated expense.
Duplicated expense can be navigated via arrows.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-01-06.at.18.58.14.mov

Android: mWeb Chrome

Screen.Recording.2026-01-06.at.18.56.44.mov

iOS: Native

Screen.Recording.2026-01-06.at.18.56.00.mov

iOS: mWeb Safari

Screen.Recording.2026-01-06.at.18.54.26.mov

MacOS: Chrome / Safari

Screen.Recording.2026-01-06.at.00.24.13.mov

codecov · 2026-01-05T16:56:36Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...stReportView/MoneyRequestReportTransactionList.tsx	`1.33% <0.00%> (-0.02%)`	⬇️
... and 57 files with indirect coverage changes

melvin-bot · 2026-01-05T17:26:36Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cretadn22 · 2026-01-06T11:51:29Z

@JS00001 Regarding the suggestion to use a derived value here, I’m a bit hesitant because the logic itself is simple, it isn’t truly “pure” because TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS depends on the currently active expense report. Because of that, I don’t think a derived value is the best fit in this case following our data management guidelines: https://github.com/cretadn22/App/blob/13338e2a686b074744f16f58660cf090924b4902/contributingGuides/philosophies/ONYX-DATA-MANAGEMENT.md?plain=1#L88

I’d love to hear your thoughts and discuss this further

JS00001 · 2026-01-06T12:59:28Z

@cretadn22 I agree with you. I originally thought that the proposal suggested something along the lines of

const [state, setState] = useState()

useEffect(() => {
  setState(...)
}, [])

I didnt see that setActiveTransactions is an onyx method. This looks good to me!

JS00001

Code LGTM, will wait on @jjcoffee 's review before merging

jjcoffee · 2026-01-06T14:07:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-app-2026-01-06_16.15.21.mp4

Android: mWeb Chrome

android-chrome-2026-01-06_16.18.19.mp4

iOS: HybridApp

ios-app-2026-01-06_15.56.30.mp4

iOS: mWeb Safari

ios-safari-2026-01-06_16.00.27.mp4

MacOS: Chrome / Safari

desktop-chrome-2026-01-06_15.29.23.mp4

jjcoffee · 2026-01-06T14:26:22Z

BUG: The navigation order is not correct - it doesn't follow the same order as the transaction list.

desktop-chrome-2026-01-06_15.24.50.mp4

cretadn22 · 2026-01-07T10:11:09Z

@jjcoffee The transaction list is currently ordered by creation time (it looks like we have support for multiple sorting options, but they’re not working at the moment). Given that, should we always order transactions by creation time, consistent with the Review Duplicates page?

App/src/pages/TransactionDuplicate/Review.tsx

Line 58 in 566a084

    
           .sort((a, b) => new Date(a?.created ?? '').getTime() - new Date(b?.created ?? '').getTime()),

App/src/pages/TransactionDuplicate/Review.tsx

Line 78 in 566a084

setActiveTransactionIDs(siblingTransactionIDsList).then(() => {

jjcoffee · 2026-01-07T13:08:52Z

@cretadn22 I would say we need to follow the way they are ordered in MoneyRequestReportTransactionList in order to avoid regressions.

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 267 to 273 in c909b33

    
           const sortedTransactions: TransactionWithOptionalHighlight[] = useMemo(() => { 
        
               return [...transactions] 
        
                   .sort((a, b) => compareValues(getTransactionValue(a, sortBy, report), getTransactionValue(b, sortBy, report), sortOrder, sortBy, localeCompare, true)) 
        
                   .map((transaction) => ({ 
        
                       ...transaction, 
        
                       shouldBeHighlighted: newTransactions?.includes(transaction), 
        
                   }));

App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

Lines 294 to 299 in c909b33

    
           const visualOrderTransactionIDs = useMemo(() => { 
        
               if (!shouldShowGroupedTransactions || groupedTransactions.length === 0) { 
        
                   return sortedTransactions.filter((transaction) => !isTransactionPendingDelete(transaction)).map((transaction) => transaction.transactionID); 
        
               } 
        
               return groupedTransactions.flatMap((group) => group.transactions.filter((transaction) => !isTransactionPendingDelete(transaction)).map((transaction) => transaction.transactionID)); 
        
           }, [groupedTransactions, sortedTransactions, shouldShowGroupedTransactions]);

I think I misunderstood your proposal, as I thought you would be updating the transaction list from MoneyRequestReportTransactionList so that we can have separation of concern and we can easily use visualOrderTransactionIDs there.

cretadn22 · 2026-01-07T16:53:39Z

@jjcoffee I updated with your suggestion

jjcoffee · 2026-01-09T07:52:56Z

Nice, thanks! Would you be able to apply the fix for the Reports screen too?

Here's the flow:

Have a workspace with delayed submit
Have 2 workspaces
On the default workspace, have no unsubmitted expenses (or no expenses at all)

Create an expense on a non-default workspace
Go to Reports->To-do->Submit
Open the expense
Go to More->Duplicate
Note the navigation arrows do not update

jjcoffee · 2026-01-09T07:54:41Z

src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx

    }, [groupedTransactions, sortedTransactions, shouldShowGroupedTransactions]);

+    useEffect(() => {
+        setActiveTransactionIDs(visualOrderTransactionIDs);


Is it worth limiting this based on the focusedRoute, so we only update when the RHP is open to avoid performance issues?

jjcoffee · 2026-01-09T07:55:07Z

Note I'll be OOO for a few days, back on the 16th.

use-setActiveTransactionIDs-dynamically

42c5067

melvin-bot bot assigned cretadn22 Jan 5, 2026

cretadn22 changed the title ~~use-setActiveTransactionIDs-dynamically~~ Fix: Cannot navigate duplicated expenses via arrow keys Jan 5, 2026

passing parentReportID

1d5694c

cretadn22 marked this pull request as ready for review January 5, 2026 17:26

cretadn22 requested review from a team as code owners January 5, 2026 17:26

melvin-bot bot requested review from heyjennahay and jjcoffee and removed request for a team January 5, 2026 17:26

melvin-bot bot removed the request for review from a team January 5, 2026 17:26

JS00001 previously approved these changes Jan 6, 2026

View reviewed changes

cretadn22 added 2 commits January 7, 2026 23:17

update activeTransactionIDs dynamically

8a3ce6e

sync the main branch

393da2f

cretadn22 dismissed JS00001’s stale review via 393da2f January 7, 2026 16:17

cretadn22 added 2 commits January 7, 2026 23:18

Fix missing newline at end of file

89c9cb5

Fix formatting

8651e1e

jjcoffee reviewed Jan 9, 2026

View reviewed changes

Fix: Cannot navigate duplicated expenses via arrow keys #78857

Are you sure you want to change the base?

Fix: Cannot navigate duplicated expenses via arrow keys #78857

Conversation

cretadn22 commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Jan 5, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Jan 5, 2026

Uh oh!

cretadn22 commented Jan 6, 2026

Uh oh!

JS00001 commented Jan 6, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee commented Jan 6, 2026

Uh oh!

cretadn22 commented Jan 7, 2026

Uh oh!

jjcoffee commented Jan 7, 2026

Uh oh!

cretadn22 commented Jan 7, 2026

Uh oh!

jjcoffee commented Jan 9, 2026

Uh oh!

jjcoffee Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Jan 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cretadn22 commented Jan 5, 2026 •

edited

Loading

codecov bot commented Jan 5, 2026 •

edited by github-actions bot

Loading

jjcoffee commented Jan 6, 2026 •

edited

Loading