Make children processes (bedrock servers) die when authtest dies #2427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Currently, whenever authtest crashes or is killed, it might left behind hanging bedrock servers which brings all sort of weird errors on next runs. Since authtest itself is the one that spawn those servers (fork/exec), let's instruct kernel do make those processes die when authtest dies.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/582719
Tests
I've made a small script to test this:
Before this PR I get several hanging bedrock processes:
After this PR I get no hanging bedrock:
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes