Skip to content

Conversation

@heekinho
Copy link
Contributor

@heekinho heekinho commented Dec 29, 2025

Details

Currently, whenever authtest crashes or is killed, it might left behind hanging bedrock servers which brings all sort of weird errors on next runs. Since authtest itself is the one that spawn those servers (fork/exec), let's instruct kernel do make those processes die when authtest dies.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/582719

Tests

I've made a small script to test this:

#!/bin/sh

# Start by killing everything
vssh pkill -9 bedrock
vssh pkill -9 authtest

# Let's simulate a crash and see how many bedrocks are left behind
vssh ./authtest -threads 12 -only "Billing.*" &

sleep 1

# Kill it!
vssh pkill -9 authtest

# Count how many processes match "my_app"
echo "Number of bedrock instances: "
vssh pgrep -c "bedrock"

# Now kill the bedrock instances
vssh pkill -9 bedrock

Before this PR I get several hanging bedrock processes:

Number of bedrock instances: 32

After this PR I get no hanging bedrock:

Number of bedrock instances: 0

Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@heekinho heekinho marked this pull request as draft December 29, 2025 23:21
@danieldoglas danieldoglas self-requested a review January 2, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant