Skip to content

Conversation

@heekinho
Copy link
Contributor

Details

Since we enabled styling/lint as requested here and we are adjusting the pipelines, we need to update the codebase or otherwise every PR will either accuse errors, have a lot of formatting distractions, or the codebase will have mixed formatting.

I hate this PR, tho. I think it's hard to review and maybe it's better for the reviewer/repo owner to run the script and apply the changes directly, instead of wasting time on review.

If you believe that's case, create a branch and run the following script:

#!/bin/bash

# Ensure the fork is added and up to date
git remote add fork https://github.com/heekinho/Bedrock.git 2>/dev/null || true
git fetch fork style-codebase

# Cherry-pick the specific commit that contains the permanent style.sh updates
# If there is a conflict (because of your local changes), Git will pause here.
git cherry-pick 246caf1e3c0ffe1fda3f1de050323f9ae909c7bd
git remote remove fork

# Use sed to replace the 'for' line
sed 's|for FILENAME.*|for FILENAME in $(find . -path "./mbedtls" -prune -o \\\( -name "*.h" -o -name "*.cpp" \\\) -print); do|' style.sh > local-style.sh

# Run it
chmod +x local-style.sh
vssh ./local-style.sh
rm local-style.sh

# Commit
git add -u
git commit -m "Run uncrustify on all .h and .cpp files"

Fixed Issues

Fixes GH_LINK

Tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@tylerkaraszewski
Copy link
Contributor

Can we break this up and do a couple of files per PR?

@heekinho
Copy link
Contributor Author

heekinho commented Jan 5, 2026

Yep. We can do that as well. I know, I also hate this PR.
I proposed that script on the OP to avoid this review because I reckon this PR is a pita haha 😆
I'll submit some PR's then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants