Skip to content

Vertex integrals #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 123 commits into
base: main
Choose a base branch
from
Open

Vertex integrals #3726

wants to merge 123 commits into from

Conversation

schnellerhase
Copy link
Contributor

@schnellerhase schnellerhase commented May 10, 2025 •
edited
Loading

Introduces the vertex integral assembler.

With the accompanying PR in FFCx FEniCS/ffcx#764 this allows for vertex integrals to be used with scalar- (rank 0) and linear forms (rank 1). Matrix assembly to follow in another PR.

Additional changes

  • adds support for running CI against branches on forks
  • kernel extraction is centralised
  • simplify compute_integration_domains (removed nested switch)

@schnellerhase schnellerhase mentioned this pull request May 16, 2025
Closed
jorgensd
jorgensd reviewed Aug 27, 2025
View reviewed changes
jorgensd
jorgensd reviewed Aug 27, 2025
View reviewed changes
jorgensd
jorgensd reviewed Aug 27, 2025
View reviewed changes
jorgensd
jorgensd reviewed Aug 27, 2025
View reviewed changes
jorgensd
jorgensd reviewed Aug 27, 2025
View reviewed changes
jorgensd
jorgensd reviewed Aug 28, 2025
View reviewed changes
jorgensd
jorgensd reviewed Aug 28, 2025
View reviewed changes
jorgensd
jorgensd reviewed Aug 28, 2025
View reviewed changes
jorgensd
jorgensd approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@jorgensd jorgensd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is good to go.
It also does a splendid job of unifying/tidying up some of the logic related to kernels, and packing of integration entities over sub-entities within form creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalhabera michalhabera michalhabera approved these changes

@jorgensd jorgensd jorgensd approved these changes

@garth-wells garth-wells Awaiting requested review from garth-wells

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schnellerhase @michalhabera @jorgensd @garth-wells