Skip to content

advance-to-point advance to the end of the current block #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

advance-to-point advance to the end of the current block #136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fdf9bf
advance-to-point advance to end of block
LukeXuan May 10, 2023
904a0a2
use the idempotent version instead
LukeXuan May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fstar-mode.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3485,9 +3485,9 @@ into blocks; process it as one large block instead."
((fstar-subp--in-tracked-region-p)
(fstar-subp-retract-until (point)))
((consp arg)
(fstar-subp-enqueue-until (point)))
(fstar-subp-enqueue-until (save-excursion (fstar-subp-next-block-start) (point))))
Copy link
Contributor

@cpitclaudel cpitclaudel May 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this case shouldn't change since it overrides the default block subdivision logic

(t
(fstar-subp-advance-until (point))))))
(fstar-subp-advance-until (save-excursion (fstar-subp-next-block-start) (point)))))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right API to call is fstar-subp--next-point-to-process


(defun fstar-subp-advance-or-retract-to-point-lax (&optional arg)
"Like `fstar-subp-advance-or-retract-to-point' with ARG, in lax mode."
Expand Down