Skip to content

[OoT] Fix room's object list display issue #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yanis002 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[OoT] Fix room's object list display issue #488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1023dbd
some hotfixes
Yanis002 Jan 2, 2025
14b9ba1
Merge remote-tracking branch 'upstream/main' into oot_hotfixes
Yanis002 Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fast64_internal/oot/room/properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ def draw_props(self, layout: UILayout, headerIndex: int, index: int, objName: st

if isLegacy:
objectName = ootData.objectData.ootEnumObjectIDLegacy[self["objectID"]][1]
elif self.objectKey == "":
# just in case there's invalid objects keys, allows users to delete them
objectName = "DELETE ME!"
Comment on lines +52 to +54
Copy link
Contributor

@Dragorn421 Dragorn421 May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since "" is not a valid value for objectKey I don't understand how this can happen

The id for deleted entries (see self.deletedEntry in OoT_ObjectData.__init__) is "None", maybe that's what should be checked here instead?
Or self.objectKey not in ootData.objectData.objectsByKey ?

elif self.objectKey != "Custom":
objectName = ootData.objectData.objectsByKey[self.objectKey].name
else:
Expand Down