forked from documentdb/documentdb
-
Notifications
You must be signed in to change notification settings - Fork 6
Use double
for all ok
fields
#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AlekSi
wants to merge
5
commits into
ferretdb
Choose a base branch
from
double-ok
base: ferretdb
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b6bc272
Use `double` for all `ok` fields
AlekSi ebf964d
Merge branch 'ferretdb' into double-ok
AlekSi 5425bfd
Merge branch 'ferretdb' into double-ok
AlekSi 686414a
Merge branch 'ferretdb' into double-ok
AlekSi bcfdeb0
Merge remote-tracking branch 'upstream/main' into double-ok
AlekSi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# FerretDB's DocumentDB Release Checklist | ||
|
||
## Preparation | ||
|
||
1. Create draft release on GitHub to see a list of merged PRs. | ||
2. Update CHANGELOG.md manually. It will point to versions of DocumentDB and FerretDB that are not released yet. | ||
3. Update `packaging/debian_files/changelog`. | ||
4. Send PR with changes, merge it. | ||
|
||
## Git tag | ||
|
||
1. Make a signed tag with `git tag -s --cleanup=verbatim vX.Y.Z-ferretdb-A.B.C(-p)` (like `v0.103.0-ferretdb-2.2.0-beta.1`), | ||
where `X.Y.Z` is the SemVar formatted version of DocumentDB (like `0.103.0`), | ||
and `A.B.C(-p)` is the compatible FerretDB version (like `2.2.0-beta.1`). | ||
2. Check `git status` output. | ||
3. Push it! | ||
|
||
## Release | ||
|
||
1. Find [Packages CI build](https://github.com/FerretDB/documentdb/actions/workflows/ferretdb_packages.yml?query=event%3Apush) | ||
for the tag to release. | ||
2. Check Docker images. | ||
3. Upload `.deb` packages to the draft release. | ||
4. Update release notes with the content of CHANGELOG.md. | ||
5. Publish release on GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
--- | ||
# see https://docs.mergify.com/ | ||
|
||
pull_request_rules: | ||
- name: "Assign PRs" | ||
conditions: | ||
- "-closed" | ||
- "#assignee = 0" | ||
actions: | ||
assign: | ||
add_users: ["{{ author }}"] | ||
|
||
- name: "Add label on conflicts" | ||
conditions: | ||
- "conflict" | ||
actions: | ||
comment: | ||
message: "@{{author}} this pull request has merge conflicts." | ||
label: | ||
add: [conflict] | ||
|
||
- name: "Remove label when conflicts were resolved" | ||
conditions: | ||
- "-conflict" | ||
actions: | ||
label: | ||
remove: [conflict] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
--- | ||
# https://github.com/repository-settings/app | ||
|
||
repository: | ||
allow_squash_merge: true | ||
allow_merge_commit: true | ||
allow_rebase_merge: false | ||
allow_auto_merge: true | ||
allow_update_branch: true | ||
delete_branch_on_merge: true | ||
enable_automated_security_fixes: true | ||
enable_vulnerability_alerts: true | ||
|
||
# https://docs.github.com/en/rest/issues/labels | ||
labels: | ||
- name: conflict | ||
color: "#FF0000" | ||
description: PRs that have merge conflicts | ||
|
||
- name: deps | ||
color: "#D4C5F9" | ||
description: PRs that update dependencies | ||
|
||
- name: not ready | ||
color: "#000000" | ||
description: Issues that are not ready to be worked on; PRs that should skip CI | ||
|
||
- name: packages | ||
color: "#9B022C" | ||
description: PRs that should build packages | ||
|
||
- name: trust | ||
color: "#00FF00" | ||
description: PRs that can access Actions secrets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
--- | ||
name: Go | ||
on: | ||
pull_request: | ||
types: | ||
- unlabeled # if GitHub Actions stuck, add and remove "not ready" label to force rebuild | ||
- opened | ||
- reopened | ||
- synchronize | ||
push: | ||
branches: | ||
- ferretdb | ||
tags: | ||
- "*" | ||
schedule: | ||
- cron: "12 0 * * *" | ||
|
||
env: | ||
GOPATH: /home/runner/go | ||
GOCACHE: /home/runner/go/cache | ||
GOLANGCI_LINT_CACHE: /home/runner/go/cache/lint | ||
GOMODCACHE: /home/runner/go/mod | ||
GOPROXY: https://proxy.golang.org | ||
GOTOOLCHAIN: local | ||
|
||
jobs: | ||
test: | ||
name: Test | ||
runs-on: ubuntu-24.04 | ||
timeout-minutes: 15 | ||
|
||
# Do not run this job in parallel for any PR change or branch push. | ||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.head_ref || github.ref_name }} | ||
cancel-in-progress: true | ||
|
||
if: github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'not ready') | ||
|
||
steps: | ||
# TODO https://github.com/FerretDB/github-actions/issues/211 | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Setup Go | ||
uses: FerretDB/github-actions/setup-go@main | ||
|
||
- name: Run tests | ||
run: | | ||
cd ferretdb_packaging | ||
go mod tidy | ||
go mod verify | ||
go test ./... | ||
|
||
- name: Check dirty | ||
if: always() | ||
run: | | ||
git status --untracked-files --ignored | ||
git status | ||
git diff --exit-code | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 3 months ago
To fix the issue, we need to add a
permissions
block to the workflow or job to explicitly limit the permissions of theGITHUB_TOKEN
. Since the workflow only requires read access to repository contents, we can setcontents: read
at the job level. This ensures the workflow has the minimal permissions necessary to complete its tasks.The changes will be made in the
.github/workflows/ferretdb_go_tests.yml
file:permissions
block under thetest
job.contents: read
as the permission.