Skip to content

Length of reply message #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Length of reply message #721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ const ReplyToMessage = ({ message }: { message: Message }) => {

<p className="text-sm">
<strong>{message.replyTo.from.username}</strong>:{" "}
{message.replyTo.content}
{message.replyTo.content.length < 20
? message.replyTo.content
: `${message.replyTo.content.slice(0, 20)}...`}
Comment on lines +50 to +52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance message truncation implementation

The current implementation has several areas for improvement:

  1. The character limit is hard-coded
  2. The truncation might not handle multi-byte characters or emojis correctly
  3. Missing accessibility considerations for screen readers

Consider this improved implementation:

-          {message.replyTo.content.length < 20
-            ? message.replyTo.content
-            : `${message.replyTo.content.slice(0, 20)}...`}
+          <span title={message.replyTo.content}>
+            {message.replyTo.content.length <= MAX_REPLY_LENGTH
+              ? message.replyTo.content
+              : `${message.replyTo.content.slice(0, MAX_REPLY_LENGTH)}…`}
+          </span>

Add this constant at the top of the file:

const MAX_REPLY_LENGTH = 20; // Maximum length for reply message preview

The improvements include:

  • Using a named constant for better maintainability
  • Adding a title attribute for accessibility
  • Using proper ellipsis character (…)
  • Wrapping in a span for better semantic structure

</p>
</div>
);
Expand Down
Loading