Skip to content

Commit c961ebd

Browse files
committed
BadFunctions/Backticks: minor efficiency fix
Only set variables if they are actually needed, not before.
1 parent 8dc9eae commit c961ebd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Security/Sniffs/BadFunctions/BackticksSniff.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@ public function register() {
2626
* @return void
2727
*/
2828
public function process(File $phpcsFile, $stackPtr) {
29-
$utils = \PHPCS_SecurityAudit\Security\Sniffs\UtilsFactory::getInstance();
30-
$tokens = $phpcsFile->getTokens();
3129
$closer = $phpcsFile->findNext(T_BACKTICK, $stackPtr + 1, null, false, null, true);
3230
if (!$closer) {
3331
return;
3432
}
3533

36-
$s = $stackPtr;
34+
$utils = \PHPCS_SecurityAudit\Security\Sniffs\UtilsFactory::getInstance();
35+
$tokens = $phpcsFile->getTokens();
36+
$s = $stackPtr;
3737
while (($s = $phpcsFile->findNext(T_VARIABLE, ($s + 1), $closer)) !== false) {
3838
$msg = 'System execution with backticks detected with dynamic parameter';
3939
if ($utils::is_token_user_input($tokens[$s])) {

0 commit comments

Comments
 (0)