Skip to content

bugfix(banktransferfragment): check fragment state #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bugfix(banktransferfragment): check fragment state #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23467ab
bugfix(banktransferfragment): call Fragment `isAdded()` to confirm fr…
codeismail-waver Aug 18, 2025
2fcb48c
bugfix(francmobilemoneyfragment): handle potential nullpointer except…
codeismail-waver Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ..._android/src/main/java/com/flutterwave/raveandroid/banktransfer/BankTransferFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,16 @@ private void clearErrors() {

@Override
public void onPollingCanceled(String flwRef, String txRef, final String responseAsJSONString) {
showBackToApp(getString(R.string.bant_transfer_polling_cancelled_message), responseAsJSONString);
if(isAdded()){
showBackToApp(getString(R.string.bant_transfer_polling_cancelled_message), responseAsJSONString);
}
}

@Override
public void onPollingTimeout(String flwRef, String txRef, final String responseAsJSONString) {
showBackToApp(getString(R.string.pay_with_bank_timeout_notification), responseAsJSONString);
if(isAdded()){
showBackToApp(getString(R.string.pay_with_bank_timeout_notification), responseAsJSONString);
}
}

private void showBackToApp(String transferStatusMessage, final String responseAsJSONString) {
Expand Down
6 changes: 4 additions & 2 deletions .../src/main/java/com/flutterwave/raveandroid/francMobileMoney/FrancMobileMoneyFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public void onPhoneValidated(String phoneToSet, boolean isEditable) {
@Override
public void showProgressIndicator(boolean active) {

if (getActivity().isFinishing()) {
if (getActivity() == null || getActivity().isFinishing()) {
return;
}

Expand Down Expand Up @@ -260,7 +260,9 @@ public void showFetchFeeFailed(String message) {
}

public void showToast(String message) {
Toast.makeText(getActivity(), message, Toast.LENGTH_SHORT).show();
if(getActivity() != null){
Toast.makeText(getActivity(), message, Toast.LENGTH_SHORT).show();
}
}

@Override
Expand Down