fix: maintain smart back button behavior with view transitions #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antoinekm is attempting to deploy a commit to the Team Bearstudio Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
ready ! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
antoinekm
force-pushed
the
fix/client-router-back-button
branch
from
37ea887 to
0d70f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @ivan-dalmet, here is the fix, this implementation is less sexy than #281, but it makes sense to do it if it's only for the back button. The smart back button functionality now works correctly while still maintaining smooth transitions between pages.
Changes
<ClientRouter />component toRootLayoutfor view transitionsBackButtoncomponent to work with client-side navigation