Skip to content

Conversation

@ArthurKun21
Copy link

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Description

Creating an accessible build for testing PR-related builds. The code was copy-paste from https://github.com/FreeTubeApp/FreeTube/blob/development/.github/workflows/build.yml while updating the name of uploads to have PR-<pr-number>

Since we already have nightly builds for the development branch, I figured it won't be too bad to also have a nightly build for PRs for test

Also made it a separate workflow file for separate tracking in the actions tab

Screenshots

Testing

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

I made a sample here ArthurKun21#6 fixed the naming problem that I didn't noticed.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 7, 2026 05:53
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 7, 2026
auto-merge was automatically disabled January 7, 2026 06:09

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 7, 2026 06:09
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to test pull requests you should use dev mode, on the rare occasion that a custom build including pull request changes is actually needed one will be provided and as a user you really should not use changes from pull requests before they have been reviewed and tested. So doing full builds for every pull request is a waste of CI resources and puts users at risk as they'll be using completely untested and unvalidated builds, test build workflows only make sense for projects where they are actually needed (e.g. NewPipe because you need to install it on your phone).

If you really want to use unvalidated and untested changes, you can always create custom builds for yourself, but I don't think we should be encouraging people to do it, especially not mislabeling them as nightly builds.

This also would not have helped with the recent build and release workflow breakage, as GitHub uses the workflow file from the default branch (in FreeTube's case the development branch) with the pull_request_target trigger for security reasons.

@absidue absidue closed this Jan 7, 2026
auto-merge was automatically disabled January 7, 2026 06:23

Pull request was closed

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 7, 2026
@ArthurKun21 ArthurKun21 deleted the create-build-pr branch January 7, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants