refactor: Update wrong fluid fraction error message #3917
+223
−8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -902,7 +902,10 @@ void CompositionalMultiphaseBase::initializeFluidState( MeshLevel & mesh, | |||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| RAJA::ReduceSum< parallelDeviceReduce, localIndex > localNegativeValues( 0 ); | ||||||||||||||||||||||||||
| RAJA::ReduceSum< parallelDeviceReduce, localIndex > localSupFrac( 0 ); | ||||||||||||||||||||||||||
| RAJA::ReduceSum< parallelDeviceReduce, localIndex > localInfFrac( 0 ); | ||||||||||||||||||||||||||
| RAJA::ReduceMin< parallelDeviceReduce, localIndex > localMinFrac( LvArray::NumericLimits< localIndex >::max ); | ||||||||||||||||||||||||||
| RAJA::ReduceMax< parallelDeviceReduce, localIndex > localMaxFrac( LvArray::NumericLimits< localIndex >::min ); | ||||||||||||||||||||||||||
| forAll< parallelDevicePolicy<> >( subRegion.size(), [=] GEOS_HOST_DEVICE ( localIndex const ei ) | ||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||
| real64 sumCompFrac = 0.0; | ||||||||||||||||||||||||||
|
|
@@ -912,19 +915,31 @@ void CompositionalMultiphaseBase::initializeFluidState( MeshLevel & mesh, | |||||||||||||||||||||||||
| if( compFrac[ei][ic] < 0.0 ) | ||||||||||||||||||||||||||
| localNegativeValues += 1; | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| localMinFrac.min( sumCompFrac ); | ||||||||||||||||||||||||||
| localMaxFrac.max( sumCompFrac ); | ||||||||||||||||||||||||||
| if( LvArray::math::abs( sumCompFrac - 1.0 ) > 1e-6 ) | ||||||||||||||||||||||||||
| localSupFrac += 1; | ||||||||||||||||||||||||||
| if( LvArray::math::abs( sumCompFrac - 1.0 ) < 1e-6 ) | ||||||||||||||||||||||||||
| localInfFrac += 1; | ||||||||||||||||||||||||||
|
Comment on lines
920
to
+923
Contributor
There was a problem hiding this comment. You must adapt the computation here:
Suggested change
Collaborator
There was a problem hiding this comment. fixed tolerance is probably ok |
||||||||||||||||||||||||||
| } ); | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| localMinFrac = MpiWrapper::min( localMinFrac.get() ); | ||||||||||||||||||||||||||
| localMaxFrac = MpiWrapper::max( localMaxFrac.get() ); | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| localIndex const negativeValues = MpiWrapper::sum( localNegativeValues.get() ); | ||||||||||||||||||||||||||
| GEOS_ERROR_IF( negativeValues > 0, | ||||||||||||||||||||||||||
| GEOS_FMT( "{}: negative global component fraction values found in subregion '{}' for {} elements", | ||||||||||||||||||||||||||
| getName(), subRegion.getName(), negativeValues ) ); | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| localIndex const totalSupFrac = MpiWrapper::sum( localSupFrac.get() ); | ||||||||||||||||||||||||||
| localIndex const totalInfFrac = MpiWrapper::sum( localInfFrac.get() ); | ||||||||||||||||||||||||||
| localIndex const totalWrongCompFrac = totalSupFrac + totalInfFrac; | ||||||||||||||||||||||||||
| localIndex const infFrac = MpiWrapper::min( localMinFrac.get() ); | ||||||||||||||||||||||||||
| localIndex const supFrac = MpiWrapper::sum( localMaxFrac.get() ); | ||||||||||||||||||||||||||
|
Comment on lines
+937
to
+938
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||||||||||||||||||||||
| GEOS_ERROR_IF( totalWrongCompFrac > 0, | ||||||||||||||||||||||||||
| GEOS_FMT( "Component fractions go from {} to {} ( over {} elements ) in subregion '{}', but should always sum to 1.0", | ||||||||||||||||||||||||||
| infFrac, supFrac, totalWrongCompFrac, subRegion.getName() ), | ||||||||||||||||||||||||||
| getDataContext()); | ||||||||||||||||||||||||||
|
Comment on lines
+939
to
+942
Contributor
There was a problem hiding this comment.
Suggested change
|
||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| // Assume global component fractions have been prescribed. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.