Skip to content

refactor: Reformat to respect ruff rules #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2025
Merged

refactor: Reformat to respect ruff rules #77

merged 4 commits into from
Apr 7, 2025

Conversation

@mlemayTTE
Copy link
Contributor

@mlemayTTE mlemayTTE commented Apr 7, 2025 •
edited
Loading

Following PR #65 where ruff was included in the CI, refactor geos-hdf5-wrapper, geos-time-history and geos-xml-tools to honor ruff formatting rules.

@mlemayTTE mlemayTTE changed the title Reformat to respect ruff rules Refactor: Reformat to respect ruff rules Apr 7, 2025
@mlemayTTE mlemayTTE changed the title Refactor: Reformat to respect ruff rules refactor: Reformat to respect ruff rules Apr 7, 2025
@mlemayTTE mlemayTTE marked this pull request as ready for review April 7, 2025 13:51
@mlemayTTE mlemayTTE requested a review from alexbenedicto April 7, 2025 13:52
@mlemayTTE mlemayTTE self-assigned this Apr 7, 2025
@mlemayTTE mlemayTTE mentioned this pull request Apr 7, 2025
Merged
alexbenedicto
alexbenedicto approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@alexbenedicto alexbenedicto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe the choice between "typing" and "typing_extensions" libraries does not seem clear enough to me as to which one we should use. This can be discussed in another job.

@alexbenedicto alexbenedicto merged commit fa4c4a2 into main Apr 7, 2025
39 checks passed
@alexbenedicto alexbenedicto deleted the lemay/refactor/ruff_formatting branch April 7, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexbenedicto alexbenedicto alexbenedicto approved these changes

Assignees

@mlemayTTE mlemayTTE

Labels

flag: ready for review type: cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mlemayTTE @alexbenedicto