Add Scanner Module #82
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Addresses issue: #41
This resolves #41 when it merges.
🛠 Summary of changes
Adds a scanner module to the shared terraform. This was created for the FAC to satisfy an ATO requirement which wanted us to scan and detect malicious fragments for all files in the s3. The flask app that we made looks into the target s3, scans everything, waits, and then rescans. We send off an alert to new relic and move the file to a different s3 bucket to quarantine it. None of that functionality is present in this module, and does require a custom solution depending on the teams tech stack to use.
TF Tests
I wrote the baseline tests, but since this module both requires a
service_binding
but has no default, perhaps you might be willing to take a look at this @rahearnNote
This is fully complete on porting over, so feel free to edit however you would like @rahearn @mogul . I have a few cleanup tasks to do for the FAC, but wanted to get this PR out so you have it and can bring it through when you would like!
📜 Testing Plan
This was tested using the following: