Remove view_notifications unused code #2991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Thank you, @heyitsmebev!
You're right in that this is no longer used in what we've developed and it makes no sense to continue carrying it with us. The other pages we have now (e.g., the dashboard and activity page) provide the same info and are more optimized than this seems to be. The interface isn't fully wired up properly, either.
I agree, this can go, thank you for cleaning it up! 🎉
ccostino
deleted the
2986-remove-unused-notifications-routes-from-jobspy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #2986
The route was unused/dead code. No other part of the application was linking to or calling this route.
The difference,
view_job_notifications_tableshows notifications for a specific job/bulk send, whileview_notificationswas supposed to show all notifications across all jobs (but nothing was using it).