Skip to content

Conversation

SpecialBuilder32
Copy link
Member

@SpecialBuilder32 SpecialBuilder32 commented Feb 12, 2025

Adds 1.21.4. item model definition files to the resource pack, and moves existing models to an overlay for backwards compatibility.

Remaining tasks:

  • Testing in-game
  • RP marked valid versions (1.21.3 should not throw warning)
  • Restore backwards compatibility for shamir textures
  • Fix vanilla item-model forwarding

@Bloo-dev Bloo-dev added needs-testing Requires in-game testing tool This is related to our build pipeline labels Feb 14, 2025
@misode misode self-requested a review February 23, 2025 20:17
Copy link
Member

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting lots of resource pack load errors.
image
image

@SpecialBuilder32
Copy link
Member Author

SpecialBuilder32 commented Mar 2, 2025

I'm getting lots of resource pack load errors.

I was almost certain it did support item-model-definition compounds both when I tested it and re the wiki.
image
I'll do some more digging and see why I didn't get this problem on my end and/or what has changed

@misode
Copy link
Member

misode commented Mar 11, 2025

@SpecialBuilder32 Have you had time to look further into these issues? Given that 1.21.5-pre1 just released, it would be ideal if this PR is ready to be merged before we have to worry with the 1.21.5 update.

@SpecialBuilder32
Copy link
Member Author

In tracking down what the load errors were, I realized there were some special cases I needed to manually handle. I had thought it was just the end fishing elytra but now that I see build errors I realize armor trims must also be redone :/

@SpecialBuilder32
Copy link
Member Author

Alright just a quick update on this - after running into too many edge cases, I'm half-rewriting the 1.20.4/1.20.5 update to make more sense and handle model-file/item-definition interactions better. It'll be a fair amount of more testing and debugging until this is ready. Sorry 😢

@misode misode changed the base branch from master to ver/1.21 May 25, 2025 21:19
@misode
Copy link
Member

misode commented May 25, 2025

@SpecialBuilder32 With #1107 being merged now, is this PR also good to go?

@Bloo-dev
Copy link
Member

For future people reading this: RP support for 1.21.4 is still missing as of today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-testing Requires in-game testing tool This is related to our build pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants