Skip to content

untested better randomness #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

untested better randomness #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b2e89
use secure random for real randomness
cauerego Jan 22, 2021
0c5105d
use u random for faster generation
cauerego Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import java.util.HashSet;
import java.util.List;
import java.util.Locale;
import java.util.Random;
import java.security.SecureRandom;
import java.util.Set;

public class RandUtils {
Expand Down Expand Up @@ -57,7 +57,12 @@ private static int generateNumInRange(int min, int max) {
}

private static int generateNumInPosRange(int min, int max) {
Random random = new Random();
Random random;
try {
random = SecureRandom.getInstance("NativePRNGNonBlocking");
} catch (NoSuchAlgorithmException nsae) {
random = new SecureRandom();
}
return random.nextInt((max - min) + 1) + min;
}

Expand Down