Skip to content

Conversation

Esteban82
Copy link
Member

This PR updates the documentation to indicate that the -J option is optional.

@Esteban82 Esteban82 requested review from a team August 13, 2025 11:49
@Esteban82 Esteban82 self-assigned this Aug 13, 2025
@Esteban82 Esteban82 added the documentation Improve documentation label Aug 13, 2025
@Esteban82
Copy link
Member Author

See discussion in #8695

@Esteban82
Copy link
Member Author

Is there someone that would like to revise this?

@Esteban82
Copy link
Member Author

Should I merge this directly? or someone would like to revise it?

@joa-quim
Copy link
Member

Don't remember when -J stop being mandatory to some modules, and not sure where that happens also. For example in psbasemap we have this line

n_errors += gmt_M_check_condition (GMT, !GMT->common.J.active, "Must specify a map projection with the -J option\n");

but still that is not activated when -J is not used.

Also, we cannot just move -J to optional and not explaining what happens in the default case. explain_-J.rst_ does not say a word about that and probably cannot because that file is included in modules where -J is mandatory (grdproject, etc...).

At the end, I would perhaps just leave things as they are. They have served us well for > 30 years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improve documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants