Skip to content

fix: ensure submenu is aligned correctly in reference to the parent menu with floating-ui/react #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix: ensure submenu is aligned correctly in reference to the parent menu with floating-ui/react #2868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Dialog/DialogAnchor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export function useDialogAnchor<T extends HTMLElement>({
// update is non-null only if popperElement is non-null
update?.();
}
}, [open, popperElement, update]);
}, [open, placement, popperElement, update]);

if (popperElement && !open) {
setPopperElement(null);
Expand Down
5 changes: 4 additions & 1 deletion src/components/Dialog/hooks/usePopoverPosition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,15 @@ export function usePopoverPosition({
}: UsePopoverParams) {
const autoMw = autoMiddlewareFor(placement);
const offsetMiddleware = toOffsetMw(offset);
const isSidePlacement = placement.startsWith('left') || placement.startsWith('right');

const middleware = [
// offset first (mirrors common Popper setups)
...(offsetMiddleware ? [offsetMiddleware] : []),

// choose between autoPlacement (Popper's "auto*") OR flip()
...(autoMw ? [autoMw] : allowFlip ? [flipMw()] : []),
// only allow flip when not explicitly 'left*' or 'right*'
...(autoMw ? [autoMw] : allowFlip && !isSidePlacement ? [flipMw()] : []),

// viewport collision adjustments
...(allowShift ? [shiftMw({ padding: 8 })] : []),
Expand All @@ -93,6 +95,7 @@ export function usePopoverPosition({
return useFloating({
middleware,
placement: seedPlacement,
strategy: 'fixed',
whileElementsMounted: freeze
? undefined
: (reference, floating, update) =>
Expand Down