-
Notifications
You must be signed in to change notification settings - Fork 44
fix(samples): disable explicit modules #1074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughSets SWIFT_ENABLE_EXPLICIT_MODULES = NO across multiple Xcode build configurations for the iOS Runner project, applying to both Runner and ScreenSharing targets. No code or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
=====================================
Coverage 4.82% 4.82%
=====================================
Files 591 591
Lines 40402 40402
=====================================
Hits 1949 1949
Misses 38453 38453 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎯 Goal
Related to #1066
🛠 Implementation details
ScreenSharing has no direct dependency on Flutter and because of that you cannot compile from xcode directly. It doesn't affect
flutter run
though🧪 Testing
Run from xcode 26
☑️Contributor Checklist
General
☑️Reviewer Checklist
Summary by CodeRabbit