Added prev/next navigation support for text, images, video. Fixed Firefox spurious br tag insertion issue. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efox spurious br tag insertion issue.
stakx
approved these changes
Dec 13, 2020
stakx
left a comment
stakx
left a comment
There was a problem hiding this comment.
Looks good. I did stumble on a few additional (but easily fixed) test failures.
| # should navigate to the previous text node. | ||
| # should navigate to the previous navigable node. | ||
| ev.preventDefault() | ||
| ev.stopPropagation() |
There was a problem hiding this comment.
This (as well as the other addition of ev.stopPropagation()) will cause a few tests to fail unless you add
dummy implementation in src/spec/text.coffee. (You might also have to recompile the specs using grunt spec.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds improved keyboard navigation "to" support for text, images, and video. That is, navigating to non-text elements. Navigating away "from" images and video is a separate commit.
This also fixes the navigation issue in Firefox for spurious 'br' tags.
Partially fixes some of the issues in GetmeUK/ContentTools#487