feat(metrics): add lua script for prometheus metrics on latency #59
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
ixxeL2097
force-pushed
the
fspiers/ENT-3136/lua-script-prometheus
branch
from
f1b0dd6 to
d56628e
Compare
ixxeL2097
force-pushed
the
fspiers/ENT-3136/lua-script-prometheus
branch
from
d56628e to
cabf26f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 10
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| init_by_lua_block { | ||
| local prom = require "docker.nginx.prometheus" | ||
| prom.init() |
There was a problem hiding this comment.
Bug: Lua Module Path Mismatch Causes Runtime Errors
The require "docker.nginx.prometheus" statement expects prometheus.lua at docker/nginx/prometheus.lua, but the file is installed at /etc/ggbridge/prometheus.lua. This path mismatch prevents the module from loading, causing runtime errors in the init_by_lua_block and log_by_lua_block.
Additional Locations (1)
| runtime: | ||
| - nginx | ||
| - nginx-mod-stream | ||
| - lua-resty-core |
There was a problem hiding this comment.
Bug: Prometheus Module Missing in Dependency List
Prometheus functionality is broken because the lua-resty-prometheus package, which provides the resty.prometheus module used by prometheus.lua, is missing. Only lua-resty-core was added as a dependency.
| local prometheus = require "resty.prometheus" | ||
| prometheus:collect() | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Prometheus Metrics Initialization Failure
The /metrics endpoint calls prometheus:collect() without initializing a lua-resty-prometheus instance. This causes a runtime error and prevents it from accessing metrics stored in the prometheus_metrics shared dictionary, which the stream context uses.
1 participant
No description provided.