-
Couldn't load subscription status.
- Fork 2
feat: show vault information in results #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kash-jay
merged 3 commits into
main
from
kashyapajayasekera/scrt-5903-add-secret-path-and-vault-instance-information-to-vs-code
Sep 29, 2025
Merged
feat: show vault information in results #96
kash-jay
merged 3 commits into
main
from
kashyapajayasekera/scrt-5903-add-secret-path-and-vault-instance-information-to-vs-code
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevbch
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi @GabrielCousin, it's be great to have a front-end review 👀 on this PR from you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Showing the vault information when a detected secret is found in a vault.
PR check list
Note
Adds vault details to diagnostics when a secret is vaulted, updating types, parser, tests, and utilities.
incident.secret_vaultedis true; otherwise show NO.vaultInfoblock.Incidentto a discriminated union adding vaulted properties:vault_type,vault_name,vault_path,vault_path_countwhensecret_vaulted: true.scanResultsVaultedfixture and new test asserting vault details.pluralize(num, word)helper and use it for vault locations.Written by Cursor Bugbot for commit 2179972. This will update automatically on new commits. Configure here.