propagate ChannelID for status reporting & initial email worker setup #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `Subscriber` and `DeliveryJob` types (and their corresponding Spanner adapters and tests) to include `ChannelID`. This identifier is needed for the Email Worker to report delivery status (success/failure) back to the `NotificationChannelState` table. Changes: - **Worker Types**: Added `ChannelID` to `EmailSubscriber` and `EmailDeliveryJob`. - **Event Types**: Added `ChannelID` to `EmailJobEvent`. - **Spanner Adapter**: Updated `FindSubscribers` to populate `ChannelID` from the query results. - **Pub/Sub Adapter**: Updated `PublishEmailJob` to pass the ID through. - **Email Worker**: Initial scaffolding for `sender` package (interfaces/mocks) that will utilize this ID.
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt1
branch
from
4a02bc8 to
d4f7e59
Compare
jcscottiii
commented
Dec 29, 2025
| slog.ErrorContext(ctx, "failed to record channel failure", "channel_id", job.ChannelID, "error", dbErr) | ||
| } | ||
|
|
||
| // Return error to NACK the message and retry sending? |
Collaborator
Author
There was a problem hiding this comment.
FYI: Better error handling happens in this PR: #2144
jrobbins
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
SubscriberandDeliveryJobtypes (and their corresponding Spanner adapters and tests) to includeChannelID. This identifier is needed for the Email Worker to report delivery status (success/failure) back to theNotificationChannelStatetable.Changes:
ChannelIDtoEmailSubscriberandEmailDeliveryJob.ChannelIDtoEmailJobEvent.FindSubscribersto populateChannelIDfrom the query results.PublishEmailJobto pass the ID through.senderpackage (interfaces/mocks) that will utilize this ID.