feat(email): Pass job triggers to email delivery jobs #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the email delivery job by including the associated job triggers. Previously, the `EmailDeliveryJob` struct did not contain trigger information, which limited the ability to customize email content based on why a notification was sent. This change introduces a `Triggers []JobTrigger` field to `lib/workertypes/EmailDeliveryJob` and `lib/event/emailjob/v1/EmailJobEvent`. Helper functions are added to `lib/event/emailjob/v1/types.go` for converting between internal `workertypes.JobTrigger` and `emailjob/v1.JobTrigger` types. Additionally, the `SummaryHighlight` struct in `lib/workertypes/types.go` now includes a `MatchesTrigger` method, encapsulating the logic for checking if a highlight satisfies a given trigger. This method is then utilized in `workers/push_delivery/pkg/dispatcher/dispatcher.go` within the `matchesTrigger` function, centralizing the trigger matching logic. The `EmailWorkerSubscriberAdapter` in `lib/gcppubsub/gcppubsubadapters/email_worker.go` and `PushDeliveryPublisher` in `lib/gcppubsub/gcppubsubadapters/push_delivery.go` are updated to correctly pass and receive these triggers. Corresponding tests have also been updated to reflect these changes. This refactoring allows the email worker to eventually render more dynamic and personalized email content based on the specific triggers that caused the notification.
jcscottiii
force-pushed
the
jcscottiii/email-worker-pt7
branch
from
ec7c818 to
fb69239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the email delivery job by including the associated job triggers.
Previously, the
EmailDeliveryJobstruct did not contain trigger information, which limited the ability to customize email content based on why a notification was sent.This change introduces a
Triggers []JobTriggerfield tolib/workertypes/EmailDeliveryJobandlib/event/emailjob/v1/EmailJobEvent. Helper functions are added tolib/event/emailjob/v1/types.gofor converting between internalworkertypes.JobTriggerandemailjob/v1.JobTriggertypes.Additionally, the
SummaryHighlightstruct inlib/workertypes/types.gonow includes aMatchesTriggermethod, encapsulating the logic for checking if a highlight satisfies a given trigger. This method is then utilized inworkers/push_delivery/pkg/dispatcher/dispatcher.gowithin thematchesTriggerfunction, centralizing the trigger matching logic.The
EmailWorkerSubscriberAdapterinlib/gcppubsub/gcppubsubadapters/email_worker.goandPushDeliveryPublisherinlib/gcppubsub/gcppubsubadapters/push_delivery.goare updated to correctly pass and receive these triggers. Corresponding tests have also been updated to reflect these changes.This refactoring allows the email worker to eventually render more dynamic and personalized email content based on the specific triggers that caused the notification.