-
Notifications
You must be signed in to change notification settings - Fork 311
Rotate and delete with Moveable rotatable #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hchiam
wants to merge
12
commits into
GoogleChromeLabs:main
Choose a base branch
from
hchiam:rotate-and-delete-613
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
64e1ade
fix #538: plugin for CT scan of <head>
hchiam 45f7e56
Merge branch 'GoogleChromeLabs:main' into main
hchiam e2f837f
Merge branch 'GoogleChromeLabs:main' into main
hchiam 91f87a7
Merge branch 'GoogleChromeLabs:main' into main
hchiam a768320
Merge branch 'GoogleChromeLabs:main' into main
hchiam 7422313
npm i moveable
hchiam 2139edb
technically got Moveable rotatable working
hchiam 8dd8029
got delete button to show up at least
hchiam 657ef9a
recreated the 10px offset
hchiam 9fda949
only the change in common.js actually prevented labelling the moveabl…
hchiam 08963dd
delete the deleteButton and the element itself and destroy moveable r…
hchiam 892c468
put :not(visbug-label) back from testing
hchiam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,6 +89,8 @@ export const isOffBounds = node => | |
|| node.closest('visbug-corners') | ||
|| node.closest('visbug-grip') | ||
|| node.closest('visbug-gridlines') | ||
|| node.closest('.moveable-control') | ||
|| node.closest('visbug-moveable-delete-button') | ||
Comment on lines
+92
to
+93
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. adding this didn't seem to help |
||
) | ||
|
||
export const isSelectorValid = (qs => ( | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,4 +44,4 @@ export const altKey = window.navigator.platform.includes('Mac') | |
? 'opt' | ||
: 'alt' | ||
|
||
export const notList = ':not(vis-bug):not(script):not(hotkey-map):not(.visbug-metatip):not(visbug-label):not(visbug-handles):not(visbug-corners):not(visbug-grip):not(visbug-gridlines)' | ||
export const notList = ':not(vis-bug):not(script):not(hotkey-map):not(.visbug-metatip):not(visbug-label):not(visbug-handles):not(visbug-corners):not(visbug-grip):not(visbug-gridlines):not(.moveable-control):not(visbug-moveable-delete-button)' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. only adding this here actually helped |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
ables
option for adding things like a custom delete button seems to only work withreact
andreact-moveable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lame!