Skip to content

Handle missing dataproc-role metadata in hive-lineage.sh #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codelixir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle missing dataproc-role metadata in hive-lineage.sh #1371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hive-lineage/hive-lineage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ function install_jars() {
}

function restart_hive_server2_master() {
ROLE=$(curl -f -s -H Metadata-Flavor:Google http://metadata/computeMetadata/v1/instance/attributes/dataproc-role)
# Safely get metadata without failing the script if the key is missing
ROLE=$(/usr/share/google/get_metadata_value attributes/dataproc-role || echo "Unknown")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve encapsulation and prevent the ROLE variable from potentially leaking into the global scope, it's a good practice to declare it as a local variable within the function.

Suggested change
ROLE=$(/usr/share/google/get_metadata_value attributes/dataproc-role || echo "Unknown")
local ROLE=$(/usr/share/google/get_metadata_value attributes/dataproc-role || echo "Unknown")

if [[ "${ROLE}" == 'Master' ]]; then
echo "Restarting hive-server2"
sudo systemctl restart hive-server2.service
Expand Down