Skip to content

Conversation

@Kartikeyapise
Copy link
Member

@Kartikeyapise Kartikeyapise commented Jan 5, 2026

Added support for new field key-project-resolution-mode in autokey config and support autokey config for project resource(details in go/cloudkms-autokey-aaow-api-contracts)

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 5, 2026
@github-actions github-actions bot requested a review from shuyama1 January 5, 2026 14:29
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code generator was migrated from Ruby to Go.

Could you please update the code in this PR to align with the current Go-based implementation?

https://googlecloudplatform.github.io/magic-modules/reference/ruby-go-changes/
https://googlecloudplatform.github.io/magic-modules/develop/add-resource/

@Kartikeyapise Kartikeyapise force-pushed the autokey-project-support branch from e3894b9 to b37cd93 Compare January 6, 2026 10:07
@github-actions github-actions bot requested a review from shuyama1 January 6, 2026 10:08
@Kartikeyapise
Copy link
Member Author

The code generator was migrated from Ruby to Go.

Could you please update the code in this PR to align with the current Go-based implementation?

https://googlecloudplatform.github.io/magic-modules/reference/ruby-go-changes/ https://googlecloudplatform.github.io/magic-modules/develop/add-resource/

Have migrated to go @shuyama1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants