Skip to content

Conversation

@onspsk
Copy link

@onspsk onspsk commented Jan 5, 2026

Fixes b/464983268

To enable Terraform support for BYOIP IPv4 Usability feature, add ipCollection to
the Address resource and enableEnhancedIpv4Allocation to the PublicDelegatedPrefix resource.

Release Note Template for Downstream PRs

compute: added `ip_collection` field to `google_compute_address` resource
compute: added `enable_enhanced_ipv4_allocation` field to `google_compute_public_delegated_prefix` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 5, 2026
@github-actions github-actions bot requested a review from trodge January 5, 2026 18:46
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/compute-ipam and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 5, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 166 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 7 files changed, 166 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 96 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 106 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1320
Passed tests: 1233
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeAddress_computeAddressEnhancedByoipExample
  • TestAccComputeFutureReservation_futureReservationAggregateReservationExample
  • TestAccComputeFutureReservation_sharedFutureReservationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeAddress_computeAddressEnhancedByoipExample [Error message] [Debug log]
TestAccComputeFutureReservation_futureReservationAggregateReservationExample [Error message] [Debug log]
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016
Copy link
Member

zli82016 commented Jan 7, 2026

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 7, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 166 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 7 files changed, 166 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 96 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 106 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1320
Passed tests: 1233
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeAddress_computeAddressEnhancedByoipExample
  • TestAccComputeFutureReservation_futureReservationAggregateReservationExample
  • TestAccComputeFutureReservation_sharedFutureReservationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeAddress_computeAddressEnhancedByoipExample [Error message] [Debug log]
TestAccComputeFutureReservation_futureReservationAggregateReservationExample [Error message] [Debug log]
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@trodge
Copy link
Contributor

trodge commented Jan 7, 2026

Test fails with

2026-01-07T20:03:08.145Z [WARN]  sdk.helper_resource: Error running Terraform CLI command:
  error=
  | exit status 1
  | 
  | Error: Error creating Address: googleapi: Error 400: Invalid resource usage: 'PublicDelegatedPrefix and address must be in the same project and scope.'., invalidResourceUsage
  | 
  |   with google_compute_address.default,
  |   on terraform_plugin_test.tf line 2, in resource "google_compute_address" "default":
  |    2: resource "google_compute_address" "default" {
  | 

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/compute-ipam

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants