feat: support new field server_certificate_rotation_mode for SQL instances #16072
Conversation
modular-magician
added
the
awaiting-approval
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
service/sqladmin-cp
and removed
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
settings {
ip_configuration {
enable_private_path_for_google_cloud_services = # value needed
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 137 Click here to see the affected service packages
Action takenFound 65 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go.tmpl
Outdated
Show resolved
Hide resolved
modular-magician
added
the
awaiting-approval
modular-magician
removed
the
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_sql_database_instance" "primary" {
settings {
ip_configuration {
enable_private_path_for_google_cloud_services = # value needed
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
|
Tests analyticsTotal tests: 137 Click here to see the affected service packages
Action takenFound 31 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
| "ssl_mode": ipConfiguration.SslMode, | ||
| "server_ca_mode": ipConfiguration.ServerCaMode, | ||
| "server_ca_pool": ipConfiguration.ServerCaPool, | ||
| "server_certificate_rotation_mode": ipConfiguration.ServerCertificateRotationMode, |
There was a problem hiding this comment.
A bunch of tests failed in this PR #16072 (comment).
resource_sql_database_instance_test.go:1052: Step 1/2 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# google_sql_database_instance.instance will be updated in-place
~ resource "google_sql_database_instance" "instance" {
id = "tf-test-bkfrxgq263"
name = "tf-test-bkfrxgq263"
# (21 unchanged attributes hidden)
~ settings {
# (21 unchanged attributes hidden)
~ ip_configuration {
+ custom_subject_alternative_names = []
- server_certificate_rotation_mode = "SERVER_CERTIFICATE_ROTATION_MODE_UNSPECIFIED" -> null
# (7 unchanged attributes hidden)
The reason is that the API returns SERVER_CERTIFICATE_ROTATION_MODE_UNSPECIFIED by default.
Can you try to fix this?
One solution could be that checking the value of ipConfiguration.ServerCertificateRotationMode. If the value is not SERVER_CERTIFICATE_ROTATION_MODE_UNSPECIFIED, then add server_certificate_rotation_mode to the data.
3 participants
Uh oh!
There was an error while loading. Please reload this page.