Skip to content

Conversation

@Gorlami96
Copy link
Contributor

@Gorlami96 Gorlami96 commented Jan 7, 2026

Terraform support for adding new value to link_type enum in Interconnect resource. b/461786426

compute: added `BPS_400G` enum value to `bandwidth` field in `google_compute_interconnect_attachment` resource

@github-actions github-actions bot requested a review from roaks3 January 7, 2026 15:15
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect_attachment (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect_attachment" "primary" {
  bandwidth = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1319
Passed tests: 1233
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_futureReservationAggregateReservationExample
  • TestAccComputeFutureReservation_sharedFutureReservationExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_futureReservationAggregateReservationExample [Error message] [Debug log]
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures look unrelated

One other thing to mention if you could respond before merging: you might want to consider using a String instead of Enum for this field on Terraform if it needs to change frequently enough. You lose client-side validation, but if the server validates as well with a reasonable message, it is a small cost for never needing to update values here (+ waiting multiple days for it to be released).

@Gorlami96
Copy link
Contributor Author

LGTM, test failures look unrelated

One other thing to mention if you could respond before merging: you might want to consider using a String instead of Enum for this field on Terraform if it needs to change frequently enough. You lose client-side validation, but if the server validates as well with a reasonable message, it is a small cost for never needing to update values here (+ waiting multiple days for it to be released).

This field doesn't really change all that frequently. But I will consider it nonetheless in the future.

@github-actions github-actions bot requested a review from roaks3 January 8, 2026 06:00
@roaks3 roaks3 added this pull request to the merge queue Jan 8, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 4f694c7 Jan 8, 2026
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants