-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adding 400g interconnect attachment bandwidth #16089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 400g interconnect attachment bandwidth #16089
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_interconnect_attachment" "primary" {
bandwidth = # value needed
}
|
Tests analyticsTotal tests: 1319 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
roaks3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, test failures look unrelated
One other thing to mention if you could respond before merging: you might want to consider using a String instead of Enum for this field on Terraform if it needs to change frequently enough. You lose client-side validation, but if the server validates as well with a reasonable message, it is a small cost for never needing to update values here (+ waiting multiple days for it to be released).
This field doesn't really change all that frequently. But I will consider it nonetheless in the future. |
4f694c7
Terraform support for adding new value to link_type enum in Interconnect resource. b/461786426