-
Notifications
You must be signed in to change notification settings - Fork 34
feat(#2802):upgrade the repo with angular 20 #2974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
83263ec
to
915ab4f
Compare
8b4737f
to
4372ef6
Compare
311738d
to
b26d687
Compare
Can you squash the non-drawer commits into one, then having just 2 commits in this PR? |
3b97718
to
0534e41
Compare
Hi @chrisolsen I rebased this with alpha and fixed tests. It is ready. |
ebd0b24
to
a512658
Compare
onMount(() => { | ||
addMessageListener(); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is the exception: we cannot rely on *ngIf=isReady
and add a delay on dropdown-item.ts
to render (even I add 1 ms delay than the goab-dropdown
, it doesn't work. relay
event here should be after when both dropdown & dropdown item renders.
a512658
to
4da39a6
Compare
Signed-off-by: Vanessa Tran <vanessa.m.tran@gov.ab.ca>
4da39a6
to
1bb1fac
Compare
Before (the change)
After (the change)
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
You can use my example repo for angular 20:
https://stackblitz.com/~/github.com/vanessatran-ddi/ui-components-angular-sandbox/tree/angular-20?file=package.json
When using angular 20 with our production libraries, you will see those errors that this PR is trying to fix. Errors have been recorded #2802 description.
You should symlink the package json of the angular 20 repo with your local build. Like this:

This is for angular 19:
https://stackblitz.com/~/github.com/vanessatran-ddi/ui-components-angular-sandbox/tree/angular-19?file=package.json
Angular 17 is https://stackblitz.com/~/github.com/GovAlta/ui-components-angular-sandbox?file=package.json
The Angular CircularProgress.ts has been updated to allow for the additional code required to get the components working with Angular to reside within the Angular component. The changes in this file must also be done in the other Angular components as well.
In addition, the Svelte components will also require that the existing
await tick()
function call within theonMount
hook can be removed, as well as thesetTimeout
calls also within theonMount
hook.