Skip to content

Conversation

vanessatran-ddi
Copy link
Collaborator

@vanessatran-ddi vanessatran-ddi commented Aug 15, 2025

Before (the change)

After (the change)

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

You can use my example repo for angular 20:
https://stackblitz.com/~/github.com/vanessatran-ddi/ui-components-angular-sandbox/tree/angular-20?file=package.json

When using angular 20 with our production libraries, you will see those errors that this PR is trying to fix. Errors have been recorded #2802 description.

You should symlink the package json of the angular 20 repo with your local build. Like this:
image

This is for angular 19:
https://stackblitz.com/~/github.com/vanessatran-ddi/ui-components-angular-sandbox/tree/angular-19?file=package.json

Angular 17 is https://stackblitz.com/~/github.com/GovAlta/ui-components-angular-sandbox?file=package.json

⚠️ Still Required Changes ✅ - this has been updated

The Angular CircularProgress.ts has been updated to allow for the additional code required to get the components working with Angular to reside within the Angular component. The changes in this file must also be done in the other Angular components as well.

In addition, the Svelte components will also require that the existing await tick() function call within the onMount hook can be removed, as well as the setTimeout calls also within the onMount hook.

‼️ Temporarily this PR will not support angular 16, I talked with Chris and would confirm if angular 16 is removed from our support:

image
  • if we still want to support angular 16, I will need to downgrade this PR to angular 18 (if you see package.json, we are upgrading to angular 20).

@vanessatran-ddi vanessatran-ddi marked this pull request as draft August 15, 2025 19:32
@vanessatran-ddi vanessatran-ddi self-assigned this Aug 15, 2025
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2802 branch 2 times, most recently from 83263ec to 915ab4f Compare August 18, 2025 22:50
@vanessatran-ddi vanessatran-ddi linked an issue Aug 19, 2025 that may be closed by this pull request
19 tasks
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2802 branch 3 times, most recently from 8b4737f to 4372ef6 Compare August 21, 2025 22:42
@vanessatran-ddi vanessatran-ddi changed the title Vanessa/2802 feat(#2802):upgrade the repo with angular 20 Aug 21, 2025
@vanessatran-ddi vanessatran-ddi marked this pull request as ready for review August 21, 2025 22:43
@chrisolsen
Copy link
Collaborator

Can you squash the non-drawer commits into one, then having just 2 commits in this PR?

@vanessatran-ddi vanessatran-ddi marked this pull request as draft September 2, 2025 21:57
@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2802 branch 3 times, most recently from 3b97718 to 0534e41 Compare September 24, 2025 19:19
@vanessatran-ddi
Copy link
Collaborator Author

Hi @chrisolsen I rebased this with alpha and fixed tests. It is ready.

@vanessatran-ddi vanessatran-ddi force-pushed the vanessa/2802 branch 4 times, most recently from ebd0b24 to a512658 Compare October 7, 2025 15:40
onMount(() => {
addMessageListener();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is the exception: we cannot rely on *ngIf=isReady and add a delay on dropdown-item.ts to render (even I add 1 ms delay than the goab-dropdown, it doesn't work. relay event here should be after when both dropdown & dropdown item renders.

@vanessatran-ddi vanessatran-ddi marked this pull request as ready for review October 7, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Angular 20

2 participants