-
Notifications
You must be signed in to change notification settings - Fork 34
feat(#2955): update Text Input component for V2 #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2-2998-coded-component-updates
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I have some questions and recommendations about the CSS. Let me know if you want to discuss anything.
0b53969
to
534141e
Compare
Thanks @bdfranck, all changes made. I also noticed a couple small issues with the styling on the text and border of the trailing/leading content specifically on the disabled state, fixed that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one more small tweak.
534141e
to
8854f46
Compare
@bdfranck Updated! |
Summary
Updates the Input (TextField) component to support V2 design system styling
while maintaining full backward compatibility with V1.
Changes
New Props
version
("1" | "2"
, default"1"
): Controls V1 vs V2 stylingsize
("default" | "compact"
, default"default"
): Controls inputheight (56px vs 40px)
V2 Styling Updates
Focus State
version="1"
Size Variants
State Styling
inputs/color/text/disabled
tokenfor input text and leading/trailing content
(
inputs/color/background/readonly
) and border(
inputs/color/border/readonly
)inputs/color/text/placeholder
tokenOther Improvements
Technical Implementation
Token Remapping Pattern
V2 CSS Scoping
.v2
class selectorTesting
All changes tested in web components playground with:
Screenshots
Before
After
Related