feat(#3095): Tabs v2 styling update #3101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twjeffery
changed the title
twjeffery
changed the title
bdfranck
requested changes
Oct 10, 2025
| gap: var(--goa-tabs-gap-small-screen); | ||
| padding-bottom: var(--goa-space-m); | ||
| margin-bottom: 2rem; | ||
| padding-bottom: var(--goa-tabs-padding-bottom-mobile); |
There was a problem hiding this comment.
This variable is undefined with v1 tokens. Don't forget to add the space-m fallback.
| :global([role="tab"][aria-selected="true"]) { | ||
| font: var(--goa-tab-typography-selected); | ||
| color: var(--goa-tab-color-text-selected); |
There was a problem hiding this comment.
This variable is undefined with v1 tokens.
| border: none; | ||
| font: var(--goa-tab-typography); | ||
| color: var(--goa-tab-text-color); | ||
| color: var(--goa-tab-color-text-not-selected); |
There was a problem hiding this comment.
This variable is undefined with v1 tokens.
| :global([role="tab"]:hover:not([aria-selected="true"])) { | ||
| border-bottom: var(--goa-tab-border-hover); | ||
| color: var(--goa-tab-color-text-hover); |
There was a problem hiding this comment.
This variable is undefined with v1 tokens.
| border-left: var(--goa-tab-border-hover); | ||
| border-bottom: none; | ||
| border-left: var(--goa-tab-border-hover); | ||
| background: var(--goa-tab-color-bg-hover-small-screen); |
There was a problem hiding this comment.
This variable is undefined with v1 tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Tabs component to support V2 design system styling while
maintaining full backward compatibility with V1.
Changes
New Props
version("1" | "2", default"1"): Controls V1 vs V2 stylingV2 Styling Updates
Typography & Colors
(
color.interactive.default)color.greyscale.600)color.text.default)Spacing
8px 4px 9px 4px(adjusted for 3px indicator + visualspacing)
4px 12px 4px 15px(accommodates left-side indicator)Active Indicators
color.interactive.default)color.greyscale.300) with rounded cornersState Styling
rounded corners
background (
color.greyscale.50)(
color.greyscale.150)Other Improvements
color.info.light)Technical Implementation
Token + CSS Approach
::after) required for rounded corner indicatorsV2 CSS Scoping
.v2class selectorTesting
All changes tested in web components playground with:
Related