fix(#3248): sync the dropdown values when children are added/removed #3122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisolsen
force-pushed
the
chris/2333-dropdown-reset
branch
from
cb1d528 to
21662a4
Compare
chrisolsen
requested review from
ArakTaiRoth,
twjeffery and
willcodeforcoffee
and removed request for
twjeffery
chrisolsen
force-pushed
the
chris/2333-dropdown-reset
branch
2 times, most recently
from
f8387bd to
8b474ca
Compare
ArakTaiRoth
reviewed
Dec 3, 2025
chrisolsen
force-pushed
the
chris/2333-dropdown-reset
branch
from
23d242f to
62d4a9e
Compare
ArakTaiRoth
previously approved these changes
Dec 4, 2025
chrisolsen
changed the title
chrisolsen
changed the title
chrisolsen
force-pushed
the
chris/2333-dropdown-reset
branch
from
62d4a9e to
9a2984d
Compare
ArakTaiRoth
approved these changes
Dec 4, 2025
Collaborator
|
🎉 This PR is included in version 1.40.0-dev.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 6.10.0-dev.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing dynamically bound dropdown items, if the items are reduced and no new items are added, the dropdown items would not change.
Before (the change)
After (the change)
Bind the values [red, green, blue], view the dropdown items to see the 3 items
Bind the value [red], you will now just see red
Browser tests written
Tested in React
Tested in Angular
Tested Web components
Steps needed to test
Test code exists in the
prsfolder => 2333