Add handler for deferred execution of messages #2951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueDoctor
force-pushed
the
defer-handler
branch
from
7f30d29 to
45095a3
Compare
TrueDoctor
force-pushed
the
defer-handler
branch
from
3fb53af to
35ce634
Compare
adamgerhant
reviewed
Jul 28, 2025
| @@ -1435,6 +1435,20 @@ impl MessageHandler<DocumentMessage, DocumentMessageContext<'_>> for DocumentMes | |||
| }, | |||
| }) | |||
| } | |||
| // Some parts of the editior depend on these bounds to be present | |||
There was a problem hiding this comment.
what parts? (answer: zooming to fill bounds) Ideally the editor should not be aware of the bounds at all, since it treats the top left corner of the vieport at (0,0). Only the executor should know the bounds in order to evaluate the node graph.
adamgerhant
reviewed
Jul 28, 2025
editor/src/messages/portfolio/document/document_message_handler.rs
Outdated
Show resolved
Hide resolved
adamgerhant
reviewed
Jul 28, 2025
| DeferMessage::AfterGraphRun { mut messages } => { | ||
| self.after_graph_run.extend(messages.drain(..).map(|m| (self.current_graph_submission_id, m))); | ||
| } | ||
| DeferMessage::AfterViewportReady { messages } => { |
There was a problem hiding this comment.
It should not be possible to add messages to this buffer if there are currently bounds. An if statement in here would be a good prevention.
There was a problem hiding this comment.
That is not the responsibility of this message handler and would violate architectural separation. And it is possible to use this callback even if bounds are present and the code still works
adamgerhant
reviewed
Jul 28, 2025
adamgerhant
reviewed
Jul 28, 2025
editor/src/messages/tool/common_functionality/graph_modification_utils.rs
Show resolved
Hide resolved
adamgerhant
reviewed
Jul 28, 2025
TrueDoctor
force-pushed
the
defer-handler
branch
from
35ce634 to
a42965f
Compare
Keavon
changed the title
TrueDoctor
force-pushed
the
defer-handler
branch
from
f962d8f to
56e66e9
Compare
TrueDoctor
force-pushed
the
defer-handler
branch
from
56e66e9 to
366c3ff
Compare
Keavon
reviewed
Jul 28, 2025
Keavon
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids blocking all message processing until a graph execution has been completed