Add selection subtracting for node graph #3290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
| HintGroup(vec![ | ||
| HintInfo::mouse(MouseMotion::LmbDrag, "Select Area"), | ||
| HintInfo::keys([Key::Shift], "Extend").prepend_plus(), | ||
| HintInfo::keys([Key::Alt], "Subtract").prepend_plus(), |
There was a problem hiding this comment.
Not sure if subtracting is the right terminology.
There was a problem hiding this comment.
It should be, that's how the graphite select tool and the wider ecosystem terms it: https://www.google.com/search?q=subtract%20selection (though I believe Pinta uses the proper set vocabulary which is pretty neat)
wade-cheng
force-pushed
the
node-selection-alt-subtract
branch
from
2573298 to
220d630
Compare
wade-cheng
force-pushed
the
node-selection-alt-subtract
branch
from
220d630 to
e721e25
Compare
|
!build |
|
|
Just keeping things rebased with master. Thanks for the rebuild 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not close any issue, but I was looking into #2532, a Paper Cut issue that requests parity between the canvas and node graph by adding the lasso select, which has no keybind conflicts. This is my very first PR here, and it was a bit out of my depth.
I wanted to start a bit smaller, and noticed that the node graph could include alt-to-subtract selections without keybind conflicts, because none of the alt keybinds correspond to left clicks on the background!
2025-10-15.16-54-19.mp4
All the other Alt keybinds like Move Duplicate and Preview Node Output still work as expected.