Skip to content

Conversation

@esmenard
Copy link

What

Fix #4397

Implementation Details

Copper is not handled correctly by the automatic creation of ingot -> nugget recipes, due to the ingot being vanilla while the nugget is added by GregTech. This PR adds this recipe manually.

Outcome

If the disableManualCompression config is set fo false, a recipe is added that turns 1 Copper Ingot into 9 Copper Nuggets

@esmenard esmenard requested a review from a team as a code owner December 28, 2025 16:05
Copy link
Contributor

@krossgg krossgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to RecipeAddition#disableManualCompression

@krossgg krossgg added type: bugfix General bug fixes Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Dec 28, 2025
@esmenard
Copy link
Author

Done

Comment on lines 142 to +145
VanillaRecipeHelper.addShapelessRecipe(provider, "nether_quartz_block_to_nether_quartz",
new ItemStack(Items.QUARTZ, 4), Blocks.QUARTZ_BLOCK);
VanillaRecipeHelper.addShapelessRecipe(provider, "nugget_disassembling_copper",
ChemicalHelper.get(nugget, Copper, 9), new ItemStack(Items.COPPER_INGOT));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VanillaRecipeHelper.addShapelessRecipe(provider, "nether_quartz_block_to_nether_quartz",
new ItemStack(Items.QUARTZ, 4), Blocks.QUARTZ_BLOCK);
VanillaRecipeHelper.addShapelessRecipe(provider, "nugget_disassembling_copper",
ChemicalHelper.get(nugget, Copper, 9), new ItemStack(Items.COPPER_INGOT));
VanillaRecipeHelper.addShapelessRecipe(provider, "nether_quartz_block_to_nether_quartz",
new ItemStack(Items.QUARTZ, 4), Blocks.QUARTZ_BLOCK);
VanillaRecipeHelper.addShapelessRecipe(provider, "copper_ingot_to_copper_nuggets",
ChemicalHelper.get(nugget, Copper, 9), new ItemStack(Items.COPPER_INGOT));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. type: bugfix General bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to convert Copper Ingot into Copper Nuggets when manual compression is reenabled

3 participants