-
Notifications
You must be signed in to change notification settings - Fork 324
Add recipe for Copper Ingot disassembling #4399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
esmenard
wants to merge
2
commits into
GregTechCEu:1.20.1
Choose a base branch
from
esmenard:fix-copper-nugget-recipe
base: 1.20.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krossgg
reviewed
Dec 28, 2025
Contributor
krossgg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to RecipeAddition#disableManualCompression
Author
|
Done |
jurrejelle
requested changes
Jan 5, 2026
Comment on lines
142
to
+145
| VanillaRecipeHelper.addShapelessRecipe(provider, "nether_quartz_block_to_nether_quartz", | ||
| new ItemStack(Items.QUARTZ, 4), Blocks.QUARTZ_BLOCK); | ||
| VanillaRecipeHelper.addShapelessRecipe(provider, "nugget_disassembling_copper", | ||
| ChemicalHelper.get(nugget, Copper, 9), new ItemStack(Items.COPPER_INGOT)); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| VanillaRecipeHelper.addShapelessRecipe(provider, "nether_quartz_block_to_nether_quartz", | |
| new ItemStack(Items.QUARTZ, 4), Blocks.QUARTZ_BLOCK); | |
| VanillaRecipeHelper.addShapelessRecipe(provider, "nugget_disassembling_copper", | |
| ChemicalHelper.get(nugget, Copper, 9), new ItemStack(Items.COPPER_INGOT)); | |
| VanillaRecipeHelper.addShapelessRecipe(provider, "nether_quartz_block_to_nether_quartz", | |
| new ItemStack(Items.QUARTZ, 4), Blocks.QUARTZ_BLOCK); | |
| VanillaRecipeHelper.addShapelessRecipe(provider, "copper_ingot_to_copper_nuggets", | |
| ChemicalHelper.get(nugget, Copper, 9), new ItemStack(Items.COPPER_INGOT)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.20.1
Release: Patch - 0.0.X
Smaller changes that either are bug fixes or very minor tweaks.
type: bugfix
General bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix #4397
Implementation Details
Copper is not handled correctly by the automatic creation of ingot -> nugget recipes, due to the ingot being vanilla while the nugget is added by GregTech. This PR adds this recipe manually.
Outcome
If the
disableManualCompressionconfig is set fo false, a recipe is added that turns 1 Copper Ingot into 9 Copper Nuggets