feat: table/column/flow COMMENT #7060
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
| let partition_column_names: Vec<_> = | ||
| table_info.meta.partition_column_names().cloned().collect(); | ||
|
|
||
| if let Some(latest) = self |
There was a problem hiding this comment.
Why is it necessary to retrieve the table info again here?
There was a problem hiding this comment.
For some reason I haven't figured out, table info from table sometimes lacks some info like partition
There was a problem hiding this comment.
better create an issue to track this
discord9
reviewed
Oct 10, 2025
| new_flow_info.comment = comment.unwrap_or_default(); | ||
| new_flow_info.updated_time = Utc::now(); | ||
|
|
||
| self.update_flow_metadata(flow_id, new_flow_info).await?; |
There was a problem hiding this comment.
maybe here need to invalidity by flow id since flow info is updated?(And flow id being key to flow info)
discord9
reviewed
Oct 10, 2025
| flow_id: FlowId, | ||
| new_flow_info: FlowInfoValue, | ||
| ) -> Result<()> { | ||
| let raw_value = serde_json::to_vec(&new_flow_info) |
There was a problem hiding this comment.
new_flow_info.try_as_raw_value() maybe?
killme2008
reviewed
Oct 11, 2025
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: dennis zhuang <killme2008@gmail.com> Co-authored-by: LFC <990479+MichaelScofield@users.noreply.github.com> Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
MichaelScofield
approved these changes
Oct 29, 2025
| let partition_column_names: Vec<_> = | ||
| table_info.meta.partition_column_names().cloned().collect(); | ||
|
|
||
| if let Some(latest) = self |
There was a problem hiding this comment.
better create an issue to track this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruihang Xia waynestxia@gmail.comI hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
COMMENT ON [TABLE/COLUMN/FLOW]to set/remove commentSHOWclausesPR Checklist
Please convert it to a draft if some of the following conditions are not met.