Skip to content

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Jul 22, 2025

Depends on both #5551 and #5675. Marked as draft and won't pass CI until those are merged.


Important

Add VOL tests for h5diff and update GitHub Actions to exclude H5DIFF tests from certain runs.

  • Behavior:
    • Exclude H5DIFF tests from ctest runs in .github/workflows/vol_rest.yml.
    • Add VOL tests for h5diff in CMakeTests.cmake, generating test files for each external VOL connector.
  • Testing:
    • Add ADD_SH5_TEST and ADD_PH5_TEST macros in CMakeTests.cmake to handle serial and parallel tests for VOL connectors.
    • Implement ADD_H5_UD_TEST macro for plugin tests in CMakeTests.cmake.
  • Misc:
    • Create directories and copy necessary test files for VOL tests in CMakeTests.cmake.

This description was created by Ellipsis for 7b391e9. You can customize this summary. It will automatically update as commits are pushed.

@mattjala mattjala added Component - Tools Command-line tools like h5dump, includes high-level tools Component - Testing Code in test or testpar directories, GitHub workflows labels Jul 22, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in HDF5 - TRIAGE & TRACK Jul 22, 2025
@mattjala mattjala force-pushed the h5diff_vol_testing branch from 77ab9af to e27a29e Compare July 25, 2025 16:42
@@ -10,6 +10,15 @@
# help@hdfgroup.org.
#

include(${HDF_CONFIG_DIR}/HDF5Macros.cmake)

# System-independent path separator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be a global variable - it's likely used in multiple areas

byrnHDF
byrnHDF previously approved these changes Aug 14, 2025
@jhendersonHDF
Copy link
Collaborator

Minor naming issue but otherwise this looks good

@lrknox lrknox merged commit abada26 into HDFGroup:develop Aug 15, 2025
77 checks passed
@github-project-automation github-project-automation bot moved this from To be triaged to Done in HDF5 - TRIAGE & TRACK Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Component - Tools Command-line tools like h5dump, includes high-level tools
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants