-
-
Notifications
You must be signed in to change notification settings - Fork 307
Generate VOL tests for h5diff #5680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77ab9af
to
e27a29e
Compare
e27a29e
to
7b391e9
Compare
byrnHDF
reviewed
Aug 14, 2025
@@ -10,6 +10,15 @@ | |||
# help@hdfgroup.org. | |||
# | |||
|
|||
include(${HDF_CONFIG_DIR}/HDF5Macros.cmake) | |||
|
|||
# System-independent path separator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should be a global variable - it's likely used in multiple areas
byrnHDF
previously approved these changes
Aug 14, 2025
Minor naming issue but otherwise this looks good |
jhendersonHDF
approved these changes
Aug 15, 2025
byrnHDF
approved these changes
Aug 15, 2025
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Testing
Code in test or testpar directories, GitHub workflows
Component - Tools
Command-line tools like h5dump, includes high-level tools
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on both #5551 and #5675. Marked as draft and won't pass CI until those are merged.
Important
Add VOL tests for
h5diff
and update GitHub Actions to excludeH5DIFF
tests from certain runs.H5DIFF
tests fromctest
runs in.github/workflows/vol_rest.yml
.h5diff
inCMakeTests.cmake
, generating test files for each external VOL connector.ADD_SH5_TEST
andADD_PH5_TEST
macros inCMakeTests.cmake
to handle serial and parallel tests for VOL connectors.ADD_H5_UD_TEST
macro for plugin tests inCMakeTests.cmake
.CMakeTests.cmake
.This description was created by
for 7b391e9. You can customize this summary. It will automatically update as commits are pushed.