Skip to content

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Jul 29, 2025

close #5690


Important

Replaces sed with perl in config/libh5cc.in for editing flags when linking against static HDF5 libraries, closing issue #5690.

  • Behavior:
    • Replaces sed with perl in config/libh5cc.in for editing pc_flags when linking against static HDF5 libraries.
    • Ensures compatibility with complex regex patterns in flag substitution.
  • Misc:

This description was created by Ellipsis for 934091a. You can customize this summary. It will automatically update as commits are pushed.

Otherwise, `lib$1.a` will appear instead of `libhdf5*.a`
@jhendersonHDF
Copy link
Collaborator

I would much prefer using sed over perl here, as sed is a POSIX tool and the previous Autotools variants of the compiler wrappers were already using sed. If that's agreeable, I will fix this by either detecting the correct flag in CMake at configure time or adding a fallback to using "-r" in the compiler wrappers scripts when the "-E" option isn't supported.

@qkoziol
Copy link
Collaborator

qkoziol commented Jul 30, 2025

I would much prefer using sed over perl here, as sed is a POSIX tool and the previous Autotools variants of the compiler wrappers were already using sed. If that's agreeable, I will fix this by either detecting the correct flag in CMake at configure time or adding a fallback to using "-r" in the compiler wrappers scripts when the "-E" option isn't supported.

Agree - we should be moving away from Perl, over time.

@hyoklee hyoklee closed this Aug 4, 2025
@github-project-automation github-project-automation bot moved this from To be triaged to Done in HDF5 - TRIAGE & TRACK Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

h5cc -v Option Throws sed: invalid option -- E
3 participants