Adding ghost matching jet flavour defn #123
Conversation
clementhelsens
left a comment
clementhelsens
left a comment
There was a problem hiding this comment.
Thanks @Edler1 , please have a look at the comments
| struct ghostFlavour { | ||
| std::vector<std::vector<float>> flavour; | ||
| JetClusteringUtils::FCCAnalysesJet jets; | ||
| std::vector<float> ghostStatus; |
There was a problem hiding this comment.
is there a reason to use vector and not RVec here?
| * Jet tagging interface utilities. | ||
| */ | ||
|
|
||
| //Get flavour association of jet |
There was a problem hiding this comment.
Correct format for doxygen doc is for example /** my text */
| //Get flavour association of jet | ||
| ROOT::VecOps::RVec<int> get_flavour(ROOT::VecOps::RVec<fastjet::PseudoJet> in, ROOT::VecOps::RVec<edm4hep::MCParticleData> MCin); | ||
|
|
||
| struct ghostFlavour { |
There was a problem hiding this comment.
missing documentation line
| }; | ||
|
|
||
|
|
||
| //Get ghost flavour (MC flavour) of jet described here: .. |
There was a problem hiding this comment.
wrong format for doxygen
| ghostFlavour operator() (ROOT::VecOps::RVec<edm4hep::MCParticleData> Particle, ROOT::VecOps::RVec<int> ind, std::vector<fastjet::PseudoJet> pseudoJets, int partonFlag); | ||
| }; | ||
|
|
||
| std::vector<std::vector<float>> get_flavour(ghostFlavour ghostStruct); |
There was a problem hiding this comment.
missing documentation line
|
|
||
| std::vector<std::vector<float>> get_flavour(ghostFlavour ghostStruct); | ||
|
|
||
| JetClusteringUtils::FCCAnalysesJet get_jets(ghostFlavour ghostStruct); |
There was a problem hiding this comment.
missing documentation line
|
|
||
| JetClusteringUtils::FCCAnalysesJet get_jets(ghostFlavour ghostStruct); | ||
|
|
||
| std::vector<float> get_ghostStatus(ghostFlavour ghostStruct); |
There was a problem hiding this comment.
missing documentation line
|
|
||
| std::vector<float> get_ghostStatus(ghostFlavour ghostStruct); | ||
|
|
||
| std::vector<int> get_MCindex(ghostFlavour ghostStruct); |
There was a problem hiding this comment.
missing documentation line
| struct get_ghostFlavour { | ||
| get_ghostFlavour(int algo, float arg_radius, int arg_exclusive, float arg_cut, int arg_sorted, int arg_recombination, float arg_add1=0, float arg_add2=0); | ||
|
|
||
| int m_algo = 0; ///< flag to select jet clustering algorithm defined in JetClustering.cc (0 = kt, 1 = antikt, 2 = cambridge, 3 = eekt, 4 = ee genkt, 5 = genkt, 6 = valencia, 7 = jade) |
There was a problem hiding this comment.
Please move the default values to the function arguments and structure the struct like https://github.com/HEP-FCC/FCCAnalyses/blob/optmisations/analyzers/dataframe/Algorithms.h#L21#L33
|
Hi @clementhelsens, thanks for the helpful feedback, Kunal and I have implemented the changes following the example in Algorithms.h Maybe two comments:
We appreciate feedback on the current state of the code. |
Conflicts: analyzers/dataframe/FCCAnalyses/JetTaggingUtils.h
3 participants
Adding a function to obtain ghost matching jet flavour definition in JetTaggingUtils. Also an example analysis.py/preSel.py file to exemplify usage.