Bug fix. Change softmax dim. #271
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In line 64, Change the softmax dim from 2 to 1. According to this line, `probs = F.softmax(self.scale * probs, dim=2)# batch x k x hw` In this code, the input dimension is [batch_size, num_class, fh\*fw]. And the softmax dimension is 2, which means that the summation of the dimensions of the feature map (fh\*fw) is one. However, in my opinion, I thinke the softmax dimension should be 1 to make the summation of the dimension of the num_class (num_class) is one. The corrected code is as follows： `probs = F.softmax(self.scale * probs, dim=1)# batch x num_class x hw`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line 64, Change the softmax dim from 2 to 1.
According to this line,
probs = F.softmax(self.scale * probs, dim=2)# batch x k x hwIn this code, the input dimension is [batch_size, num_class, fh*fw]. And the softmax dimension is 2, which means that the summation of the dimensions of the feature map (fh*fw) is one.
However, in my opinion, I thinke the softmax dimension should be 1 to make the summation of the dimension of the num_class (num_class) is one.
The corrected code is as follows：
probs = F.softmax(self.scale * probs, dim=1)# batch x num_class x hwBy the way, I had report this to issue, but without answer.
And I have a simple comparative experimental verification, the results show that dim1 can convergence faster, and get a better mIOU.