-
Notifications
You must be signed in to change notification settings - Fork 139
AB#94 Update Traffic now -link look and feel #5577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8c22cfe
fix: improve icon ids
partisaani 7450f11
feat: added info icons, improved colorizing icons
partisaani 2ee2163
feat: align component with hsl.fi look and feel
partisaani 8b97dd4
feat: use updated Traffic now -link component in app, updated transla…
partisaani 7234a49
feat: refactor TrafficNowLink into main package, mark component depre…
partisaani a263609
chore: improve localization keys
partisaani 9f84149
fix: resolve error in console
partisaani 590fac1
feat: style cleanup
partisaani 1783753
Revert "feat: added info icons, improved colorizing icons"
partisaani 45b74e7
Revert "feat: align component with hsl.fi look and feel"
partisaani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import { FormattedMessage } from 'react-intl'; | ||
| import Icon from '../Icon'; | ||
|
|
||
| const TrafficNowLink = ({ handleClick, href }) => { | ||
| return ( | ||
| <a className="traffic-now__link" href={href} onClick={handleClick}> | ||
| <div className="traffic-now__link__left-column"> | ||
| <Icon | ||
| img="icon_info-filled" | ||
| color="#007ac9" | ||
| height={1.5} | ||
| width={1.5} | ||
| colorAsFillOnly={false} | ||
| /> | ||
| <div className="traffic-now__link__left-column-body"> | ||
| <FormattedMessage | ||
| id="traffic-now_link" | ||
| defaultValue="Services now" | ||
| tagName="h2" | ||
| /> | ||
| <FormattedMessage | ||
| id="traffic-now_link-description" | ||
| defaultValue="See changes and disruptions" | ||
| tagName="p" | ||
| /> | ||
| </div> | ||
| </div> | ||
| <span className="traffic-now__link__caret"> | ||
| <Icon img="icon_arrow-collapse--right" color="#007ac9" /> | ||
| </span> | ||
| </a> | ||
| ); | ||
| }; | ||
|
|
||
| TrafficNowLink.propTypes = { | ||
| handleClick: PropTypes.func.isRequired, | ||
| href: PropTypes.string, | ||
| }; | ||
|
|
||
| TrafficNowLink.defaultProps = { | ||
| href: undefined, | ||
| }; | ||
|
|
||
| export default TrafficNowLink; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need both href and click handler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
href is included for the browser to show the url preview when hovering