Skip to content

Conversation

@max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Nov 19, 2025

Related to the deprecation of Looker Studio reports that used core_web_vitals dataset:

we'll remove deprecated pipelines.

No more updates after Dec 2025 release of CrUX.

@max-ostapenko max-ostapenko marked this pull request as ready for review December 12, 2025 11:50
Copilot AI review requested due to automatic review settings December 12, 2025 11:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the technologies.js pipeline from the core_web_vitals dataset as part of deprecating the associated Looker Studio reports. However, the removal appears incomplete as several dependent pipelines still reference the table being deleted.

Key Changes:

  • Removes the entire definitions/output/core_web_vitals/technologies.js file (236 lines)
Comments suppressed due to low confidence (1)

definitions/output/core_web_vitals/technologies.js:1

  • Deleting this pipeline will break multiple dependent pipelines in the reports schema that reference core_web_vitals.technologies. The following files will fail when this table is removed:
  • definitions/output/reports/cwv_tech_adoption.js (line 25)
  • definitions/output/reports/cwv_tech_core_web_vitals.js (line 93)
  • definitions/output/reports/cwv_tech_lighthouse.js (line 70)
  • definitions/output/reports/cwv_tech_page_weight.js (line 60)

These dependent pipelines should either be removed as well, or updated to use an alternative data source before removing this table.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@max-ostapenko
Copy link
Contributor Author

Additionally there is:

@rviscomi
Copy link
Member

No plans, removing SGTM 👍

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping things clean!

@max-ostapenko max-ostapenko merged commit 1f7758f into main Dec 12, 2025
31 checks passed
@max-ostapenko max-ostapenko deleted the deprecate_cwv_looker branch December 12, 2025 14:55
@tunetheweb
Copy link
Member

routines saved to the dataset - @tunetheweb, do we still need these?

They used to be a lot more complex, but now they're fairly simple so don't really need to be in a routine. Let's keep em until end of January where we can see if anyone from Web Almanac is needlessly using these still, and then migrate if they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants