-
Notifications
You must be signed in to change notification settings - Fork 4
Remove pipelines related to a deprecated core_web_vitals dataset #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the technologies.js pipeline from the core_web_vitals dataset as part of deprecating the associated Looker Studio reports. However, the removal appears incomplete as several dependent pipelines still reference the table being deleted.
Key Changes:
- Removes the entire
definitions/output/core_web_vitals/technologies.jsfile (236 lines)
Comments suppressed due to low confidence (1)
definitions/output/core_web_vitals/technologies.js:1
- Deleting this pipeline will break multiple dependent pipelines in the reports schema that reference
core_web_vitals.technologies. The following files will fail when this table is removed:
definitions/output/reports/cwv_tech_adoption.js(line 25)definitions/output/reports/cwv_tech_core_web_vitals.js(line 93)definitions/output/reports/cwv_tech_lighthouse.js(line 70)definitions/output/reports/cwv_tech_page_weight.js(line 60)
These dependent pipelines should either be removed as well, or updated to use an alternative data source before removing this table.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Additionally there is:
|
|
No plans, removing SGTM 👍 |
tunetheweb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping things clean!
They used to be a lot more complex, but now they're fairly simple so don't really need to be in a routine. Let's keep em until end of January where we can see if anyone from Web Almanac is needlessly using these still, and then migrate if they are. |
Related to the deprecation of Looker Studio reports that used
core_web_vitalsdataset:core_web_vitals.technologiestable for https://lookerstudio.google.com/u/0/reporting/55bc8fad-44c2-4280-aa0b-5f3f0cd3d2be/core_web_vitals.technology_matrixtable for https://lookerstudio.google.com/u/2/reporting/0ad64c8f-644a-40f9-93e4-0ccd5f72b33dwe'll remove deprecated pipelines.
No more updates after Dec 2025 release of CrUX.