Skip to content

Resolving 4XX errors on the CDN #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-ostapenko merged 2 commits into from
Dec 9, 2025
Merged

Resolving 4XX errors on the CDN #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c84d0fa
Add icon existence checks and warnings in ComboBox, TechReport, and T…
max-ostapenko Dec 9, 2025
f93e002
Remove console warnings for missing icons in ComboBox, TechReport, an…
max-ostapenko Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/js/techreport/combobox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,13 @@ class ComboBox {
option.dataset.key = index;
option.textContent = row.technology;
option.id = `${this.element.dataset.id}-${row.technology.replaceAll(' ','-')}`;
const logo = document.createElement('img');
logo.setAttribute('alt', '');
logo.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${icon}`);
logo.setAttribute('loading', 'lazy');
option.append(logo);
if(icon) {
const logo = document.createElement('img');
logo.setAttribute('alt', '');
logo.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${icon}`);
Copy link

Copilot AI Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent URL encoding: The icon at line 35 is used directly without encodeURI(), but the icon at line 206 uses encodeURI(icon). For consistency and to prevent potential URL issues with special characters in icon filenames, both should use encodeURI() or encodeURIComponent().

Suggested change
logo.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${icon}`);
logo.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${encodeURI(icon)}`);

Copilot uses AI. Check for mistakes.
logo.setAttribute('loading', 'lazy');
option.append(logo);
}
if(this.selected.includes(row.technology)) {
option.setAttribute('aria-selected', true);
}
Expand Down Expand Up @@ -198,12 +200,14 @@ class ComboBox {
deleteSelection.dataset.name = name;
deleteSelection.addEventListener('click', () => this.unselectElement(name));

/* Add the app logo */
const appIcon = document.createElement('img');
appIcon.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${encodeURI(icon)}`);
appIcon.setAttribute('alt', '');
appIcon.classList.add('logo');
deleteSelection.append(appIcon);
if (icon) {
/* Add the app logo */
const appIcon = document.createElement('img');
appIcon.setAttribute('src', `https://cdn.httparchive.org/v1/static/icons/${encodeURI(icon)}`);
appIcon.setAttribute('alt', '');
appIcon.classList.add('logo');
deleteSelection.append(appIcon);
}

/* Add the delete icon */
const deleteIcon = document.createElement('img');
Expand Down
12 changes: 7 additions & 5 deletions src/js/techreport/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,7 @@ class TechReport {
// Get the information about the selected technology
getTechInfo() {
const technologies = this.filters.app;
const technology = technologies.join('%2C')
.replaceAll(" ", "%20");

const technology = technologies.map(encodeURIComponent).join(',');
const url = `${Constants.apiBase}/technologies?technology=${technology}`;

fetch(url)
Expand All @@ -315,7 +313,9 @@ class TechReport {
const categories = techInfo && techInfo.category ? techInfo.category.split(', ') : [];
DrilldownHeader.setCategories(categories);
DrilldownHeader.setDescription(techInfo.description);
DrilldownHeader.setIcon(techInfo.icon);
if (techInfo.icon) {
DrilldownHeader.setIcon(techInfo.icon);
}
});
}

Expand Down Expand Up @@ -408,7 +408,9 @@ class TechReport {
const app = this.filters.app[0];
const icon = data[app]?.at(-1)?.icon;
DrilldownHeader.update(this.filters);
DrilldownHeader.setIcon(`${encodeURI(icon)}`);
if (icon) {
DrilldownHeader.setIcon(`${encodeURI(icon)}`);
}

if(data && data[app]) {
UIUtils.updateReportComponents(this.sections, data, data[app], this.page, this.labels);
Expand Down
14 changes: 8 additions & 6 deletions src/js/techreport/tableLinked.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,14 @@ class TableLinked {
const wrapper = document.createElement('span');
wrapper.classList.add('app-wrapper');

const img = document.createElement('span');
const imgUrl = `https://cdn.httparchive.org/v1/static/icons/${encodeURI(technology[0]?.icon)}`;
img.setAttribute('aria-hidden', 'true');
img.setAttribute('style', `background-image: url(${imgUrl})`);
img.classList.add('app-img');
wrapper.append(img);
if(technology[0]?.icon) {
const img = document.createElement('span');
const imgUrl = `https://cdn.httparchive.org/v1/static/icons/${encodeURI(technology[0]?.icon)}`;
img.setAttribute('aria-hidden', 'true');
img.setAttribute('style', `background-image: url(${imgUrl})`);
img.classList.add('app-img');
wrapper.append(img);
}

const formattedApp = DataUtils.formatAppName(app);
const link = document.createElement('a');
Expand Down
Loading